5ea1cd8f6d
mdb_stat cleanup.
...
Exit with success when there was no failure.
Do not use data containing NUL as a DB name (which is a C string).
12 years ago
a1b16ce5f0
ITS#7598 Tweak MDB_<NEXT/PREV>_NODUP,fix mdb_stat.
...
MDB_NEXT_NODUP, MDB_PREV_NODUP: Allow for non-MDB_DUPSORT databases.
No mdb.c code changes needed.
mdb_stat.c: Use MDB_NEXT_NODUP, to avoid a crash with a DUPSORT mainDB.
12 years ago
1b6d7ee7e1
ITS#7598 mdb_dbi_open(named DB): Check mainDB flags.
...
Reject attempts to open named databases if the main
database has flag MDB_DUPSORT or MDB_INTEGERKEY.
DUPSORT would require an xcursor for the DB, INTEGERKEY
would expect the DB name to be a binary integer.
12 years ago
a2ce25482a
ITS#7515 Fix nested txn touch of subpage/ovpage.
...
mdb_page_touch(): Don't touch a subpage, replacing with non-subpage.
mdb_cursor_put(): Don't overwrite ancestor txn's dirty overflow page.
12 years ago
5bdf2aae6e
Tweak mdb_page_malloc(),mdb_page_get() semantics.
...
mdb_page_malloc(): Add "number of pages" parameter.
mdb_page_get(): Add output param for how page was found.
Do not set return params on error.
mdb_cursor_put(): Catch mdb_page_get() error.
Prepares for next commit, no change in caller behavior other
than on mdb_page_get error.
12 years ago
2eb50b1d2e
More ITS#7589 followup: OVPAGES() -> mp_pages.
12 years ago
e4ce404992
More ITS#7589: Fix prev commit.
...
mp_pages gives #pages in the ovpage. OVPAGES() no longer does.
12 years ago
0cdd9dffdd
ITS#7589 mdb_cursor_put(): Update ovpage nodesize.
...
Update the nodesize when overwriting an overflow page.
As before, do not attempt to shrink the page.
12 years ago
833cd905b7
Include <netinet/in.h> for Solaris 8
...
Needed for <resolv.h>, which is needed for BYTE_ORDER.
12 years ago
7233bc295b
Fix mdb_page_split - nested split
...
If updating a page's separator triggers a split in its parent,
we may have missed adjusting the parent's cursor position.
12 years ago
1105aa35ba
Doxygen cleanup
12 years ago
9ebd5992c9
Fix 66c839f029
...
Forgot #include <errno.h>
12 years ago
66c839f029
Refactor mdb_midl_append, add mdb_midl_grow()
12 years ago
2d6aed7537
ITS#7515 Fix nested transaction error handling.
...
mdb_txn_begin(): Do not free(mt_free_pgs), it needs mdb_midl_free().
mdb_txn_commit(): Catch commit(child) error.
12 years ago
521fdb00cc
Fix mdb_env_close(unopened MDB_env).
...
Do not try to scan me_dbxs in a closed/never-opened MDB_env.
Broken by 7d643d3acb151c416b46
12 years ago
0b9a208530
Simplify/cleanup mdb_cursor_init, C_ALLOCD.
...
No real change.
mdb_cursor_init() checks if it needs mx, so pass it unconditionally.
Set C_ALLOCD for shadow cursors, for clarity. (It was always set as
it should anyway from the origin cursor, which would have C_ALLOCD.)
12 years ago
f355de0298
MDB warning cleanup.
...
Unused function when MDB_DEBUG. Unused 'excl' param.
12 years ago
b389341b4b
mdb_dcmp(): Assume the database has MDB_DUPSORT.
...
There was little point in returning EINVAL when not: Comparing (A,B)
and (B,A) would claim (A > B && B > A), which could confuse callers.
12 years ago
91a93004ce
Update MDB doc: Cursors, DB handles, data lifetime
12 years ago
385889b0be
Allow mdb_cursor_close() after readonly txn ends.
...
Catch mdb_cursor_renew(write txn's cursor). Add flag C_UNTRACK, so
mdb_cursor_close need not peek inside a possibly-freed readonly txn.
12 years ago
17ffe9c992
Close cursors when commit(writer). Factor out code.
...
Close remaining cursors when committing a write txn. The doc says this
happens, and it avoids cursor tracking when updating mainDB + freeDB.
Rename mdb_cursor_merge() -> mdb_cursors_close() for code reuse,
and add a merge option. Simplify its loop a bit.
Factor out cleanup of DBIs.
12 years ago
dca0cef678
Plug txn leak and MDB_NOTLS slot leaks on error.
...
On mdb_env_copy() error: Abort the txn.
On mdb_txn_renew0() error: Release new MDB_NOTLS reader slot.
12 years ago
f45d40a88b
Cleaner "Support mdb_txn_abort(a reset txn)".
...
Redo 8a562f560e
12 years ago
151c416b46
Update fixes for dbi_open/close, ITS#7515.
...
Reset me_dbflags[dbi] when closing DBI, to get rid of MDB_VALID flag.
mdb_env_close(): Re-fix DB-name memleak. DBIs > me_numdbs may exist.
12 years ago
21da623bf4
Allow reading freelist while working on it
...
The circular dependency issues appear to have been resolved.
Still, need to watch closely, maybe revert this change if
problems arise.
12 years ago
568c22c4cc
Avoid assert
...
Due to underfilled branch page. We're in the process of merging/moving
nodes to it because we already know it's underfilled. Took this approach
rather than just removing the assert in mdb_page_search_root, because
that assert may yet catch other situations we don't know about.
(Although, it has been there since the original commit of mdb.c and
has never triggered any other times...)
12 years ago
37bd48a618
Plug mdb_cursor_renew() memleak
12 years ago
c057582573
Fix MDB_LAST, reset cursor index
12 years ago
da3e4d78d6
Fix typo from 7aba5f5ab9
12 years ago
9dd61011fe
Tweak comments/readability.
...
Show MDB_PERSISTENT/MDB_VALID/DB_VALID relationship.
mdb_txn_renew0(): Remove obsolete "cannot fail" comment.
12 years ago
272e4e98ad
Add MDB_NOTLS envflag.
12 years ago
afe488d8a9
Catch MDB txn reuse/sync errors.
12 years ago
8a562f560e
Support mdb_txn_abort(a reset txn).
12 years ago
ce6335b0d9
Cleanup for TLS key and read-only filesystem.
...
Move key init into mdb_env_setup_locks().
Don't create unused TLS key when read-only filesystem.
Drop internal flag MDB_ROFS, we can instead test either
!me_txns, !mt_u.reader or me_lfd==INVALID_HANDLE_VALUE.
12 years ago
65a6542765
Clean up MDB_env setup.
...
Malloc before I/O. Avoids possible malloc error after I/O.
Don't allocate dirty & free lists when MDB_RDONLY.
Factor out code.
12 years ago
dbb9ded2f8
Fix mdb_rebalance
...
Don't do anything with (fake root) subpages
12 years ago
aca6c08897
ITS#7574 blind fix
...
Fix 227329c8e1
12 years ago
92fc932f21
fix prev commit
12 years ago
0cccf79a02
Fix mdb_rebalance
...
Need to check NUMKEYS as well as fill threshold, when deciding
whether to change anything. Don't let the page drop below the
minimum number of keys.
12 years ago
14c5a5dff1
Revert "ITS#7570 fix MDB_GET_MULTIPLE and MDB_NEXT_MULTIPLE"
...
This reverts commit 372b3ddb85
12 years ago
372b3ddb85
ITS#7570 fix MDB_GET_MULTIPLE and MDB_NEXT_MULTIPLE
12 years ago
fbe6a6051b
Fix 227329c8e1
...
mdb_dbi_close() must allow any dbi < maxdbs, since opens in an
uncommitted txn don't increment env->me_numdbs.
12 years ago
e43fa77eaa
Revert "Fix 6beaad52129da5353fd40c0ec48e6a78c4f71a2e"
...
This reverts commit 8eef7a4275
12 years ago
227329c8e1
Fixes for dbi_open/close, ITS#7515
12 years ago
6b46799379
ITS#7561 Fix mdb_drop bugs
...
Check for overflow pages, reset cursor position properly.
12 years ago
8eef7a4275
Fix 6beaad5212
...
In APPEND don't immediately reject matching key, since this
is valid for APPENDDUP.
12 years ago
6beaad5212
Fix d3990eb2f8
...
Append mode should *reject* keys that are too small.
Also allow APPENDDUP in mdb_put().
12 years ago
e31d748dbe
Fix rebalance when collapsing root page
...
When fixing other cursors, must also fix their depth.
12 years ago
cb1cc64831
More fixes for MDB_LAST
...
Make sure C_INITIALIZED gets set on successful call
12 years ago
3213fc4db7
ITS#7556 fix cursor_sibling for PREV
12 years ago
Hallvard Furuseth