17ffe9c992
Close cursors when commit(writer). Factor out code.
...
Close remaining cursors when committing a write txn. The doc says this
happens, and it avoids cursor tracking when updating mainDB + freeDB.
Rename mdb_cursor_merge() -> mdb_cursors_close() for code reuse,
and add a merge option. Simplify its loop a bit.
Factor out cleanup of DBIs.
12 years ago
dca0cef678
Plug txn leak and MDB_NOTLS slot leaks on error.
...
On mdb_env_copy() error: Abort the txn.
On mdb_txn_renew0() error: Release new MDB_NOTLS reader slot.
12 years ago
f45d40a88b
Cleaner "Support mdb_txn_abort(a reset txn)".
...
Redo 8a562f560e
12 years ago
151c416b46
Update fixes for dbi_open/close, ITS#7515.
...
Reset me_dbflags[dbi] when closing DBI, to get rid of MDB_VALID flag.
mdb_env_close(): Re-fix DB-name memleak. DBIs > me_numdbs may exist.
12 years ago
21da623bf4
Allow reading freelist while working on it
...
The circular dependency issues appear to have been resolved.
Still, need to watch closely, maybe revert this change if
problems arise.
12 years ago
568c22c4cc
Avoid assert
...
Due to underfilled branch page. We're in the process of merging/moving
nodes to it because we already know it's underfilled. Took this approach
rather than just removing the assert in mdb_page_search_root, because
that assert may yet catch other situations we don't know about.
(Although, it has been there since the original commit of mdb.c and
has never triggered any other times...)
12 years ago
37bd48a618
Plug mdb_cursor_renew() memleak
12 years ago
c057582573
Fix MDB_LAST, reset cursor index
12 years ago
9dd61011fe
Tweak comments/readability.
...
Show MDB_PERSISTENT/MDB_VALID/DB_VALID relationship.
mdb_txn_renew0(): Remove obsolete "cannot fail" comment.
12 years ago
272e4e98ad
Add MDB_NOTLS envflag.
12 years ago
afe488d8a9
Catch MDB txn reuse/sync errors.
12 years ago
8a562f560e
Support mdb_txn_abort(a reset txn).
12 years ago
ce6335b0d9
Cleanup for TLS key and read-only filesystem.
...
Move key init into mdb_env_setup_locks().
Don't create unused TLS key when read-only filesystem.
Drop internal flag MDB_ROFS, we can instead test either
!me_txns, !mt_u.reader or me_lfd==INVALID_HANDLE_VALUE.
12 years ago
65a6542765
Clean up MDB_env setup.
...
Malloc before I/O. Avoids possible malloc error after I/O.
Don't allocate dirty & free lists when MDB_RDONLY.
Factor out code.
12 years ago
dbb9ded2f8
Fix mdb_rebalance
...
Don't do anything with (fake root) subpages
12 years ago
aca6c08897
ITS#7574 blind fix
...
Fix 227329c8e1
12 years ago
92fc932f21
fix prev commit
12 years ago
0cccf79a02
Fix mdb_rebalance
...
Need to check NUMKEYS as well as fill threshold, when deciding
whether to change anything. Don't let the page drop below the
minimum number of keys.
12 years ago
14c5a5dff1
Revert "ITS#7570 fix MDB_GET_MULTIPLE and MDB_NEXT_MULTIPLE"
...
This reverts commit 372b3ddb85
12 years ago
372b3ddb85
ITS#7570 fix MDB_GET_MULTIPLE and MDB_NEXT_MULTIPLE
12 years ago
fbe6a6051b
Fix 227329c8e1
...
mdb_dbi_close() must allow any dbi < maxdbs, since opens in an
uncommitted txn don't increment env->me_numdbs.
12 years ago
e43fa77eaa
Revert "Fix 6beaad52129da5353fd40c0ec48e6a78c4f71a2e"
...
This reverts commit 8eef7a4275
12 years ago
227329c8e1
Fixes for dbi_open/close, ITS#7515
12 years ago
6b46799379
ITS#7561 Fix mdb_drop bugs
...
Check for overflow pages, reset cursor position properly.
12 years ago
8eef7a4275
Fix 6beaad5212
...
In APPEND don't immediately reject matching key, since this
is valid for APPENDDUP.
12 years ago
6beaad5212
Fix d3990eb2f8
...
Append mode should *reject* keys that are too small.
Also allow APPENDDUP in mdb_put().
12 years ago
e31d748dbe
Fix rebalance when collapsing root page
...
When fixing other cursors, must also fix their depth.
12 years ago
cb1cc64831
More fixes for MDB_LAST
...
Make sure C_INITIALIZED gets set on successful call
12 years ago
3213fc4db7
ITS#7556 fix cursor_sibling for PREV
12 years ago
7d643d3acb
Plug MDB memory leak of DB names.
12 years ago
ccb7b26916
Silence signedness warning
12 years ago
a70b026f6b
Fix MDB_DEBUG compile when no varargs macros.
...
Variables mdb_debug, mdb_debug_start were used undefined.
12 years ago
30da15a18d
Tweak mode_t def per Hallvard's suggestion
12 years ago
7aae15739b
Fix CURSOR_LAST/CURSOR_PREV
12 years ago
863fa77a08
ITS#7553 better fix
12 years ago
8a99b00acc
ITS#7553 deinit cursor after deleting last node
12 years ago
bbb27cde4a
bugfix for mdb_cursor_put with MDB_MULTIPLE
...
If the variable dkey.mv_size is non-zero, then it means dkey
contains some original data which has to be put back in the
child db, typically when the child db has just been created.
But when using MDB_MULTIPLE, if this variable has not been
reset to zero, we may come back to this section and wrongly
think that there is some original data to be taken care of.
12 years ago
77001f549b
ITS#7538 fallout from ITS#7536 fix.
...
Allow leaf pages to have only 1 key.
12 years ago
3247d7cbd6
Precalculate max size of a node
12 years ago
8c1d95a438
Fix f97552a83a
...
Causes Bus Error on SPARC
12 years ago
f80171e079
Check for MADV_RANDOM
...
Android supports madvise but not posix_madvise
12 years ago
9c4ee82297
ITS#7377 Fix c0f3d9b9a8
...
Add missing parens
12 years ago
b1da555c4c
Turn off readahead on main mmap
...
It's harmful when the DB is larger than RAM.
12 years ago
d74330128a
ITS#7536 fix mdb_rebalance
...
A page must always have at least 2 keys (unless it's a root page)
12 years ago
26e4222ffb
Delete obsolete @todo
...
We do it now... (coalescing freelist entries in page_alloc)
12 years ago
80cd881184
Tweak MDB_INCOMPATIBLE description
12 years ago
fbd76c44e4
Tweak prev commit: Restore if-test as an assert
12 years ago
208e5c614d
ITS#7515 Fix mdb_txn_commit(nested txn).
...
Don't modify the parent txn until the current txn cannot fail.
Don't assume new dirty child pgnos > dirty parent pgnos.
Page alloc/touch: Fail if child+parent dirty pages would exceed
dirty_list's maxsize. Avoids an error situation in commit.
12 years ago
f43ae20be7
ITS#7512 Plug mdb_txn_abort(nested txn) page leaks.
...
Also catch mdb_cursor_shadow() errors.
12 years ago
f97552a83a
Check DB flags when refreshing a stale MDB DBI.
...
It's hairy to figure out when a DBI is valid. Catch destructive
user errors, and flags which another process changed under us.
12 years ago
Hallvard Furuseth