b917266ca1
Cleanup prev commit
11 years ago
41bf5c906a
Speedup deletion from spill_pgs
11 years ago
6423c87749
ITS#7671 always return the key for a dup val
11 years ago
e15a90c762
ITS#7670 Tweak cursor_del0
...
Always leave cursor pointing at "next" node, if any.
Find next sibling if we're already at end of current page.
11 years ago
6616034eb9
mdb_page_spill(): Fix nested txn mt_dirty_room
11 years ago
392be3a7c6
Simplify last commits
11 years ago
45c4ed1805
Tweak prev commit
...
If somehow "need" is larger than the list size, don't
try to fake out the dirty list.
11 years ago
7b1db13050
Less aggressive page_spill
...
spilling all possible pages is a waste because the majority will be
needed again. Just do 1/8th of the dirty list instead.
11 years ago
c22a7d98ec
Update caveats now that mdb_reader_check exists
11 years ago
214e9ed07d
Silence warnings
11 years ago
82b27c09c9
Tweak ITS#7615 fix: Obey strict-aliasing rules.
...
Do not access a long long as an array of longs.
11 years ago
76f0a02485
ITS#7664 better fix
...
For RDONLY, don't get lockfile until we know datafile exists.
Also, don't try to create a new datafile for me_mfd if someone
deleted it after we got me_fd.
11 years ago
a77ffaaa5d
Revert "ITS#7664 delete lockfile if there is no environment"
...
This reverts commit 8725838409
11 years ago
8725838409
ITS#7664 delete lockfile if there is no environment
11 years ago
eaeeecc3b2
Fix uninit'd mem ref in mdb_page_split
...
Don't compare cursors beyond their depth. (detected by valgrind)
11 years ago
6ecee1cbf9
Tweak NODUPDATA flag check
...
Should allow for the possibility of future flag combos.
11 years ago
5a5d33ff33
Fix obscure MDB_MULTIPLE bug
...
If a key has a single existing value, and then a put (MDB_MULTIPLE)
is done where the first of the multiple values matches the existing
value, the put would return SUCCESS without writing any of the
values. Fixed to loop to the next value as intended.
11 years ago
76f8b77e36
Point to mdb.c for docs on macros in Makefile
11 years ago
9c49ef1d71
Avoid compiling debug args with C90 compilers.
...
Use double DPRINTF() parenthesis, so varargs macros are not needed.
Parenthesize MDB_DEBUG, in case the user defines it as foo || bar.
11 years ago
76d31573a4
Refuse ops on bad txns
11 years ago
9beea541e1
Replace EINVALs with generalized MDB_INCOMPATIBLE.
...
Also check xcursor instead of DUPSORT, it's slightly briefer.
11 years ago
ef899fe84e
ITS#7656 fix install target
11 years ago
86551828ab
ITS#7660 Add mdb_txn_env to API
11 years ago
5645812f41
mdb_txn_commit(): Always commit if MDB_TXN_SPILLS.
...
Checking dirty_list was insufficient after a spill
with no named databases and no positioned cursors.
11 years ago
92eb220184
ITS#7661 mdb_dbi_flags(): Allow main DBI
11 years ago
335f0e4cee
mdb_del must ignore data if db not opened with MDB_DUPSORT
11 years ago
1ac3c8308f
Add mdb_env_get_maxkeysize()
11 years ago
1ecd86b14c
Replace unpredictable EINVAL error returns.
...
Return EINVAL only for simple programmer errors.
11 years ago
22c104c5d7
Re-fix reader-pid code
11 years ago
38b11b1de1
mdb_cursorpages_mark: Mark current txn and no more.
...
Ignore parent txn cursors since it is the current txn's dirty_list
which will be flushed. But check the current txn also when clearing,
since cursors can have pages which are dirty in a parent.
Check !mc_xcursor instead of !MDB_DUPSORT. Equivalent for valid
data, but a bit safer if the sub-DB flags are corrupt.
11 years ago
2bd5d8102e
Fix mdb_ovpage_free() vs. spill.
...
Ensure me_pghead has room before removing from spill/dirty list.
Don't return pages to me_pghead in nested txns, use mt_free_pgs.
11 years ago
c3547e81f3
Fix page spilling when MDB_WRITEMAP.
...
mdb_page_spill(): Don't binary-search the unsorted dirty_list.
mdb_page_flush(): Don't overwrite unprocessed dirty_list items.
11 years ago
ee5ba85565
Set MDB_TXN_ERROR when inconsistent txn state
11 years ago
ffd2287b55
Factor out MDB_env.
11 years ago
d66739f947
MDB_LOCK_VERSION -> MDB_LOCK_FORMAT.
...
Pid locking needs a different lockfile-version: MDB_env's with and
without pid locking must not coexist, they can sabotage each other.
Store MDB_LOCK_FORMAT = (version | "use locking" flag) instead.
11 years ago
1878213092
Fix mdb_reader_pid().
...
Treat unexpected errors as "don't know". Invert Pidcheck return
value, so nonzero including error codes = "the process may exist".
On Windows: Catch exited but still existing processes. Handle
undefined PROCESS_QUERY_LIMITED_INFORMATION.
On Unix: don't trust F_GETLK error to leave the input alone,
the fcntl() doc seems unclear.
11 years ago
636c2d2a29
Use proper printf format on Windows
11 years ago
74ed1757a4
Silence warnings
11 years ago
27435aa5ac
Tweak comments
11 years ago
6214423163
Clarify doc: mdb_copy, nested txns, mdb_drop().
...
mdb_copy: Does not copy lockfile. Can trigger file growth.
mdb_txn_begin(): Clarify usage restrictions.
mdb_drop(): State what to do rather than what will be done, since
closing the handle could otherwise be read as happening even at failure.
11 years ago
2cc2574d84
Tweak prev commit again
...
Make sure errors are propagated from init_meta
11 years ago
bc03467040
Fix typo in Win32 branch
11 years ago
254b77e63d
Cleanup prev commit
...
Loop on copyfd meta write, since pipes may return after partial write.
11 years ago
eff35fcb2a
ITS#7652 fix I/O error checks
...
partial revert of d6d2638acc26a25df5fc
11 years ago
acf20f77f3
Tweak mdb_envinfo numreaders
...
Return the actual shared reader count when it exists, not
just the current process env's reader count.
11 years ago
e8ba9dbd28
ITS#7615 use shorter names for semaphores
...
NetBSD can only handle up to 14 chars, we were using 21. Now
we encode to 15, and for NetBSD truncate the last char.
11 years ago
de72c08660
Tweak reader_pid check
...
Check again after acquiring rmutex. Avoids potential issue with
a duplicate pid coming in between initial check and rmutex.
12 years ago
b1dc72b6b5
Get pid lock outside of rmutex
...
Avoid holding rmutex for longer than necessary.
12 years ago
5ca73f864f
Tweak reader checks
...
Use mti_numreaders for loop limit, not me_maxreaders.
12 years ago
a4bbe57f8b
Add mdb_reader_check()
12 years ago
Howard Chu