From 54c6652ea5dbde94abca1f1946f48440bc93eccf Mon Sep 17 00:00:00 2001
From: Tpt <thomaspt@hotmail.fr>
Date: Mon, 17 Jan 2022 20:40:34 +0100
Subject: [PATCH] Improves halloween problem test

---
 testsuite/oxigraph-tests/sparql/halloween_problem.ru   |  3 +++
 .../oxigraph-tests/sparql/halloween_problem_result.ttl |  5 +++++
 testsuite/oxigraph-tests/sparql/manifest.ttl           | 10 +++++-----
 testsuite/oxigraph-tests/sparql/update_dirty_read.ru   |  3 ---
 .../oxigraph-tests/sparql/update_dirty_read_result.ttl |  3 ---
 5 files changed, 13 insertions(+), 11 deletions(-)
 create mode 100644 testsuite/oxigraph-tests/sparql/halloween_problem.ru
 create mode 100644 testsuite/oxigraph-tests/sparql/halloween_problem_result.ttl
 delete mode 100644 testsuite/oxigraph-tests/sparql/update_dirty_read.ru
 delete mode 100644 testsuite/oxigraph-tests/sparql/update_dirty_read_result.ttl

diff --git a/testsuite/oxigraph-tests/sparql/halloween_problem.ru b/testsuite/oxigraph-tests/sparql/halloween_problem.ru
new file mode 100644
index 00000000..cff7eaf4
--- /dev/null
+++ b/testsuite/oxigraph-tests/sparql/halloween_problem.ru
@@ -0,0 +1,3 @@
+PREFIX ex: <http://example.com/>
+INSERT DATA { ex:s ex:salary 1200 . ex:s2 ex:salary 1250 . ex:boss ex:salary 1600 . };
+DELETE { ?s ex:salary ?o } INSERT { ?s ex:salary ?v } WHERE { ?s ex:salary ?o FILTER(?o < 1500) BIND(?o + 100 AS ?v) }
diff --git a/testsuite/oxigraph-tests/sparql/halloween_problem_result.ttl b/testsuite/oxigraph-tests/sparql/halloween_problem_result.ttl
new file mode 100644
index 00000000..c25c63a0
--- /dev/null
+++ b/testsuite/oxigraph-tests/sparql/halloween_problem_result.ttl
@@ -0,0 +1,5 @@
+@prefix ex: <http://example.com/> .
+
+ex:s ex:salary 1300 .
+ex:s2 ex:salary 1350 .
+ex:boss ex:salary 1600 .
diff --git a/testsuite/oxigraph-tests/sparql/manifest.ttl b/testsuite/oxigraph-tests/sparql/manifest.ttl
index bb6fcc1b..9bfb1476 100644
--- a/testsuite/oxigraph-tests/sparql/manifest.ttl
+++ b/testsuite/oxigraph-tests/sparql/manifest.ttl
@@ -22,7 +22,7 @@
     :values_in_filter_not_exists
     :subquery_in_filter_not_exists
     :cmp_langString
-    :update_dirtyRead
+    :halloween_problem
     :nested_path
     :nested_expression
     ) .
@@ -96,10 +96,10 @@
     mf:action [ qt:query <cmp_langString.rq> ] ;
     mf:result <cmp_langString.srx> .
 
-:update_dirty_read rdf:type mf:UpdateEvaluationTest ;
-    mf:name "An update operation should not be able to read its own writes" ;
-    mf:action [ ut:request <update_dirtyRead.ru> ] ;
-    mf:result [ ut:data <update_dirty_read_result.ttl> ] .
+:halloween_problem rdf:type mf:UpdateEvaluationTest ;
+    mf:name "Halloween Problem: An update operation should not be able to read its own writes" ;
+    mf:action [ ut:request <halloween_problem.ru> ] ;
+    mf:result [ ut:data <halloween_problem_result.ttl> ] .
 
 :nested_path rdf:type mf:PositiveSyntaxTest11 ;
     mf:name "A very nested property path" ;
diff --git a/testsuite/oxigraph-tests/sparql/update_dirty_read.ru b/testsuite/oxigraph-tests/sparql/update_dirty_read.ru
deleted file mode 100644
index 90f852ed..00000000
--- a/testsuite/oxigraph-tests/sparql/update_dirty_read.ru
+++ /dev/null
@@ -1,3 +0,0 @@
-PREFIX ex: <http://example.com/>
-INSERT DATA { ex:s ex:p 1 . ex:s ex:p 5 };
-INSERT { ex:s ex:p ?v } WHERE { VALUES ?o { 1 2 5 6 } FILTER EXISTS { ?s ex:p ?o } BIND(?o + 1 AS ?v) }
diff --git a/testsuite/oxigraph-tests/sparql/update_dirty_read_result.ttl b/testsuite/oxigraph-tests/sparql/update_dirty_read_result.ttl
deleted file mode 100644
index e06f993b..00000000
--- a/testsuite/oxigraph-tests/sparql/update_dirty_read_result.ttl
+++ /dev/null
@@ -1,3 +0,0 @@
-@prefix ex: <http://example.com/> .
-
-ex:s ex:p 1 , 2 , 5 , 6 .