|
|
|
// Copyright (c) 2013, Facebook, Inc. All rights reserved.
|
|
|
|
// This source code is licensed under the BSD-style license found in the
|
|
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
|
|
//
|
|
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
|
|
|
|
#include "db/table_cache.h"
|
|
|
|
|
|
|
|
#include "db/filename.h"
|
|
|
|
#include "db/version_edit.h"
|
|
|
|
|
|
|
|
#include "rocksdb/statistics.h"
|
In DB::NewIterator(), try to allocate the whole iterator tree in an arena
Summary:
In this patch, try to allocate the whole iterator tree starting from DBIter from an arena
1. ArenaWrappedDBIter is created when serves as the entry point of an iterator tree, with an arena in it.
2. Add an option to create iterator from arena for following iterators: DBIter, MergingIterator, MemtableIterator, all mem table's iterators, all table reader's iterators and two level iterator.
3. MergeIteratorBuilder is created to incrementally build the tree of internal iterators. It is passed to mem table list and version set and add iterators to it.
Limitations:
(1) Only DB::NewIterator() without tailing uses the arena. Other cases, including readonly DB and compactions are still from malloc
(2) Two level iterator itself is allocated in arena, but not iterators inside it.
Test Plan: make all check
Reviewers: ljin, haobo
Reviewed By: haobo
Subscribers: leveldb, dhruba, yhchiang, igor
Differential Revision: https://reviews.facebook.net/D18513
11 years ago
|
|
|
#include "table/iterator_wrapper.h"
|
|
|
|
#include "table/table_reader.h"
|
|
|
|
#include "util/coding.h"
|
|
|
|
#include "util/stop_watch.h"
|
|
|
|
|
|
|
|
namespace rocksdb {
|
|
|
|
|
|
|
|
static void DeleteEntry(const Slice& key, void* value) {
|
|
|
|
TableReader* table_reader = reinterpret_cast<TableReader*>(value);
|
|
|
|
delete table_reader;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void UnrefEntry(void* arg1, void* arg2) {
|
|
|
|
Cache* cache = reinterpret_cast<Cache*>(arg1);
|
|
|
|
Cache::Handle* h = reinterpret_cast<Cache::Handle*>(arg2);
|
|
|
|
cache->Release(h);
|
|
|
|
}
|
|
|
|
|
|
|
|
static Slice GetSliceForFileNumber(const uint64_t* file_number) {
|
|
|
|
return Slice(reinterpret_cast<const char*>(file_number),
|
|
|
|
sizeof(*file_number));
|
|
|
|
}
|
|
|
|
|
|
|
|
TableCache::TableCache(const std::string& dbname, const Options* options,
|
[CF] Rethink table cache
Summary:
Adapting table cache to column families is interesting. We want table cache to be global LRU, so if some column families are use not as often as others, we want them to be evicted from cache. However, current TableCache object also constructs tables on its own. If table is not found in the cache, TableCache automatically creates new table. We want each column family to be able to specify different table factory.
To solve the problem, we still have a single LRU, but we provide the LRUCache object to TableCache on construction. We have one TableCache per column family, but the underyling cache is shared by all TableCache objects.
This allows us to have a global LRU, but still be able to support different table factories for different column families. Also, in the future it will also be able to support different directories for different column families.
Test Plan: make check
Reviewers: dhruba, haobo, kailiu, sdong
CC: leveldb
Differential Revision: https://reviews.facebook.net/D15915
11 years ago
|
|
|
const EnvOptions& storage_options, Cache* const cache)
|
|
|
|
: env_(options->env),
|
|
|
|
dbname_(dbname),
|
|
|
|
options_(options),
|
|
|
|
storage_options_(storage_options),
|
[CF] Rethink table cache
Summary:
Adapting table cache to column families is interesting. We want table cache to be global LRU, so if some column families are use not as often as others, we want them to be evicted from cache. However, current TableCache object also constructs tables on its own. If table is not found in the cache, TableCache automatically creates new table. We want each column family to be able to specify different table factory.
To solve the problem, we still have a single LRU, but we provide the LRUCache object to TableCache on construction. We have one TableCache per column family, but the underyling cache is shared by all TableCache objects.
This allows us to have a global LRU, but still be able to support different table factories for different column families. Also, in the future it will also be able to support different directories for different column families.
Test Plan: make check
Reviewers: dhruba, haobo, kailiu, sdong
CC: leveldb
Differential Revision: https://reviews.facebook.net/D15915
11 years ago
|
|
|
cache_(cache) {}
|
|
|
|
|
|
|
|
TableCache::~TableCache() {
|
|
|
|
}
|
|
|
|
|
|
|
|
TableReader* TableCache::GetTableReaderFromHandle(Cache::Handle* handle) {
|
|
|
|
return reinterpret_cast<TableReader*>(cache_->Value(handle));
|
|
|
|
}
|
|
|
|
|
|
|
|
void TableCache::ReleaseHandle(Cache::Handle* handle) {
|
|
|
|
cache_->Release(handle);
|
|
|
|
}
|
|
|
|
|
|
|
|
Status TableCache::FindTable(const EnvOptions& toptions,
|
|
|
|
const InternalKeyComparator& internal_comparator,
|
|
|
|
const FileDescriptor& fd, Cache::Handle** handle,
|
|
|
|
bool* table_io, const bool no_io) {
|
|
|
|
Status s;
|
|
|
|
Slice key = GetSliceForFileNumber(&fd.number);
|
|
|
|
*handle = cache_->Lookup(key);
|
|
|
|
if (*handle == nullptr) {
|
|
|
|
if (no_io) { // Dont do IO and return a not-found status
|
|
|
|
return Status::Incomplete("Table not found in table_cache, no_io is set");
|
|
|
|
}
|
|
|
|
if (table_io != nullptr) {
|
|
|
|
*table_io = true; // we had to do IO from storage
|
|
|
|
}
|
|
|
|
std::string fname = TableFileName(dbname_, fd.GetNumber());
|
|
|
|
unique_ptr<RandomAccessFile> file;
|
|
|
|
unique_ptr<TableReader> table_reader;
|
|
|
|
s = env_->NewRandomAccessFile(fname, &file, toptions);
|
|
|
|
RecordTick(options_->statistics.get(), NO_FILE_OPENS);
|
|
|
|
if (s.ok()) {
|
|
|
|
if (options_->advise_random_on_open) {
|
|
|
|
file->Hint(RandomAccessFile::RANDOM);
|
|
|
|
}
|
|
|
|
StopWatch sw(env_, options_->statistics.get(), TABLE_OPEN_IO_MICROS);
|
|
|
|
s = options_->table_factory->NewTableReader(
|
|
|
|
*options_, toptions, internal_comparator, std::move(file),
|
|
|
|
fd.GetFileSize(), &table_reader);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!s.ok()) {
|
|
|
|
assert(table_reader == nullptr);
|
|
|
|
RecordTick(options_->statistics.get(), NO_FILE_ERRORS);
|
|
|
|
// We do not cache error results so that if the error is transient,
|
|
|
|
// or somebody repairs the file, we recover automatically.
|
|
|
|
} else {
|
|
|
|
assert(file.get() == nullptr);
|
|
|
|
*handle = cache_->Insert(key, table_reader.release(), 1, &DeleteEntry);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return s;
|
|
|
|
}
|
|
|
|
|
|
|
|
Iterator* TableCache::NewIterator(const ReadOptions& options,
|
|
|
|
const EnvOptions& toptions,
|
|
|
|
const InternalKeyComparator& icomparator,
|
|
|
|
const FileDescriptor& fd,
|
|
|
|
TableReader** table_reader_ptr,
|
In DB::NewIterator(), try to allocate the whole iterator tree in an arena
Summary:
In this patch, try to allocate the whole iterator tree starting from DBIter from an arena
1. ArenaWrappedDBIter is created when serves as the entry point of an iterator tree, with an arena in it.
2. Add an option to create iterator from arena for following iterators: DBIter, MergingIterator, MemtableIterator, all mem table's iterators, all table reader's iterators and two level iterator.
3. MergeIteratorBuilder is created to incrementally build the tree of internal iterators. It is passed to mem table list and version set and add iterators to it.
Limitations:
(1) Only DB::NewIterator() without tailing uses the arena. Other cases, including readonly DB and compactions are still from malloc
(2) Two level iterator itself is allocated in arena, but not iterators inside it.
Test Plan: make all check
Reviewers: ljin, haobo
Reviewed By: haobo
Subscribers: leveldb, dhruba, yhchiang, igor
Differential Revision: https://reviews.facebook.net/D18513
11 years ago
|
|
|
bool for_compaction, Arena* arena) {
|
|
|
|
if (table_reader_ptr != nullptr) {
|
|
|
|
*table_reader_ptr = nullptr;
|
|
|
|
}
|
|
|
|
TableReader* table_reader = fd.table_reader;
|
|
|
|
Cache::Handle* handle = nullptr;
|
|
|
|
Status s;
|
|
|
|
if (table_reader == nullptr) {
|
|
|
|
s = FindTable(toptions, icomparator, fd, &handle, nullptr,
|
|
|
|
options.read_tier == kBlockCacheTier);
|
|
|
|
if (!s.ok()) {
|
In DB::NewIterator(), try to allocate the whole iterator tree in an arena
Summary:
In this patch, try to allocate the whole iterator tree starting from DBIter from an arena
1. ArenaWrappedDBIter is created when serves as the entry point of an iterator tree, with an arena in it.
2. Add an option to create iterator from arena for following iterators: DBIter, MergingIterator, MemtableIterator, all mem table's iterators, all table reader's iterators and two level iterator.
3. MergeIteratorBuilder is created to incrementally build the tree of internal iterators. It is passed to mem table list and version set and add iterators to it.
Limitations:
(1) Only DB::NewIterator() without tailing uses the arena. Other cases, including readonly DB and compactions are still from malloc
(2) Two level iterator itself is allocated in arena, but not iterators inside it.
Test Plan: make all check
Reviewers: ljin, haobo
Reviewed By: haobo
Subscribers: leveldb, dhruba, yhchiang, igor
Differential Revision: https://reviews.facebook.net/D18513
11 years ago
|
|
|
return NewErrorIterator(s, arena);
|
|
|
|
}
|
|
|
|
table_reader = GetTableReaderFromHandle(handle);
|
|
|
|
}
|
|
|
|
|
In DB::NewIterator(), try to allocate the whole iterator tree in an arena
Summary:
In this patch, try to allocate the whole iterator tree starting from DBIter from an arena
1. ArenaWrappedDBIter is created when serves as the entry point of an iterator tree, with an arena in it.
2. Add an option to create iterator from arena for following iterators: DBIter, MergingIterator, MemtableIterator, all mem table's iterators, all table reader's iterators and two level iterator.
3. MergeIteratorBuilder is created to incrementally build the tree of internal iterators. It is passed to mem table list and version set and add iterators to it.
Limitations:
(1) Only DB::NewIterator() without tailing uses the arena. Other cases, including readonly DB and compactions are still from malloc
(2) Two level iterator itself is allocated in arena, but not iterators inside it.
Test Plan: make all check
Reviewers: ljin, haobo
Reviewed By: haobo
Subscribers: leveldb, dhruba, yhchiang, igor
Differential Revision: https://reviews.facebook.net/D18513
11 years ago
|
|
|
Iterator* result = table_reader->NewIterator(options, arena);
|
|
|
|
if (handle != nullptr) {
|
|
|
|
result->RegisterCleanup(&UnrefEntry, cache_, handle);
|
|
|
|
}
|
|
|
|
if (table_reader_ptr != nullptr) {
|
|
|
|
*table_reader_ptr = table_reader;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (for_compaction) {
|
|
|
|
table_reader->SetupForCompaction();
|
|
|
|
}
|
|
|
|
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
|
|
|
Status TableCache::Get(const ReadOptions& options,
|
|
|
|
const InternalKeyComparator& internal_comparator,
|
|
|
|
const FileDescriptor& fd, const Slice& k, void* arg,
|
|
|
|
bool (*saver)(void*, const ParsedInternalKey&,
|
|
|
|
const Slice&, bool),
|
|
|
|
bool* table_io, void (*mark_key_may_exist)(void*)) {
|
|
|
|
TableReader* t = fd.table_reader;
|
|
|
|
Status s;
|
|
|
|
Cache::Handle* handle = nullptr;
|
|
|
|
if (!t) {
|
|
|
|
s = FindTable(storage_options_, internal_comparator, fd, &handle, table_io,
|
|
|
|
options.read_tier == kBlockCacheTier);
|
|
|
|
if (s.ok()) {
|
|
|
|
t = GetTableReaderFromHandle(handle);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (s.ok()) {
|
|
|
|
s = t->Get(options, k, arg, saver, mark_key_may_exist);
|
|
|
|
if (handle != nullptr) {
|
|
|
|
ReleaseHandle(handle);
|
|
|
|
}
|
|
|
|
} else if (options.read_tier && s.IsIncomplete()) {
|
|
|
|
// Couldnt find Table in cache but treat as kFound if no_io set
|
|
|
|
(*mark_key_may_exist)(arg);
|
|
|
|
return Status::OK();
|
|
|
|
}
|
|
|
|
return s;
|
|
|
|
}
|
|
|
|
Status TableCache::GetTableProperties(
|
|
|
|
const EnvOptions& toptions,
|
|
|
|
const InternalKeyComparator& internal_comparator, const FileDescriptor& fd,
|
|
|
|
std::shared_ptr<const TableProperties>* properties, bool no_io) {
|
|
|
|
Status s;
|
|
|
|
auto table_reader = fd.table_reader;
|
|
|
|
// table already been pre-loaded?
|
|
|
|
if (table_reader) {
|
|
|
|
*properties = table_reader->GetTableProperties();
|
|
|
|
|
|
|
|
return s;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool table_io;
|
|
|
|
Cache::Handle* table_handle = nullptr;
|
|
|
|
s = FindTable(toptions, internal_comparator, fd, &table_handle, &table_io,
|
|
|
|
no_io);
|
|
|
|
if (!s.ok()) {
|
|
|
|
return s;
|
|
|
|
}
|
|
|
|
assert(table_handle);
|
|
|
|
auto table = GetTableReaderFromHandle(table_handle);
|
|
|
|
*properties = table->GetTableProperties();
|
|
|
|
ReleaseHandle(table_handle);
|
|
|
|
return s;
|
|
|
|
}
|
|
|
|
|
[CF] Rethink table cache
Summary:
Adapting table cache to column families is interesting. We want table cache to be global LRU, so if some column families are use not as often as others, we want them to be evicted from cache. However, current TableCache object also constructs tables on its own. If table is not found in the cache, TableCache automatically creates new table. We want each column family to be able to specify different table factory.
To solve the problem, we still have a single LRU, but we provide the LRUCache object to TableCache on construction. We have one TableCache per column family, but the underyling cache is shared by all TableCache objects.
This allows us to have a global LRU, but still be able to support different table factories for different column families. Also, in the future it will also be able to support different directories for different column families.
Test Plan: make check
Reviewers: dhruba, haobo, kailiu, sdong
CC: leveldb
Differential Revision: https://reviews.facebook.net/D15915
11 years ago
|
|
|
void TableCache::Evict(Cache* cache, uint64_t file_number) {
|
|
|
|
cache->Erase(GetSliceForFileNumber(&file_number));
|
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace rocksdb
|