|
|
|
|
/**
|
|
|
|
|
* A MergeOperator for rocksdb that implements string append.
|
|
|
|
|
* @author Deon Nicholas (dnicholas@fb.com)
|
|
|
|
|
* Copyright 2013 Facebook
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#pragma once
|
|
|
|
|
#include "rocksdb/merge_operator.h"
|
|
|
|
|
#include "rocksdb/slice.h"
|
|
|
|
|
|
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
|
|
[RocksDB] [MergeOperator] The new Merge Interface! Uses merge sequences.
Summary:
Here are the major changes to the Merge Interface. It has been expanded
to handle cases where the MergeOperator is not associative. It does so by stacking
up merge operations while scanning through the key history (i.e.: during Get() or
Compaction), until a valid Put/Delete/end-of-history is encountered; it then
applies all of the merge operations in the correct sequence starting with the
base/sentinel value.
I have also introduced an "AssociativeMerge" function which allows the user to
take advantage of associative merge operations (such as in the case of counters).
The implementation will always attempt to merge the operations/operands themselves
together when they are encountered, and will resort to the "stacking" method if
and only if the "associative-merge" fails.
This implementation is conjectured to allow MergeOperator to handle the general
case, while still providing the user with the ability to take advantage of certain
efficiencies in their own merge-operator / data-structure.
NOTE: This is a preliminary diff. This must still go through a lot of review,
revision, and testing. Feedback welcome!
Test Plan:
-This is a preliminary diff. I have only just begun testing/debugging it.
-I will be testing this with the existing MergeOperator use-cases and unit-tests
(counters, string-append, and redis-lists)
-I will be "desk-checking" and walking through the code with the help gdb.
-I will find a way of stress-testing the new interface / implementation using
db_bench, db_test, merge_test, and/or db_stress.
-I will ensure that my tests cover all cases: Get-Memtable,
Get-Immutable-Memtable, Get-from-Disk, Iterator-Range-Scan, Flush-Memtable-to-L0,
Compaction-L0-L1, Compaction-Ln-L(n+1), Put/Delete found, Put/Delete not-found,
end-of-history, end-of-file, etc.
-A lot of feedback from the reviewers.
Reviewers: haobo, dhruba, zshao, emayanke
Reviewed By: haobo
CC: leveldb
Differential Revision: https://reviews.facebook.net/D11499
11 years ago
|
|
|
class StringAppendOperator : public AssociativeMergeOperator {
|
|
|
|
|
public:
|
|
|
|
|
// Constructor: specify delimiter
|
|
|
|
|
explicit StringAppendOperator(char delim_char);
|
|
|
|
|
explicit StringAppendOperator(const std::string& delim);
|
|
|
|
|
|
|
|
|
|
virtual bool Merge(const Slice& key, const Slice* existing_value,
|
|
|
|
|
const Slice& value, std::string* new_value,
|
|
|
|
|
Logger* logger) const override;
|
|
|
|
|
|
|
|
|
|
static const char* kClassName() { return "StringAppendOperator"; }
|
|
|
|
|
static const char* kNickName() { return "stringappend"; }
|
|
|
|
|
virtual const char* Name() const override { return kClassName(); }
|
|
|
|
|
virtual const char* NickName() const override { return kNickName(); }
|
|
|
|
|
|
|
|
|
|
private:
|
|
|
|
|
std::string delim_; // The delimiter is inserted between elements
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|
