|
|
|
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
|
|
|
|
#pragma once
|
|
|
|
|
|
|
|
#include <ctime>
|
|
|
|
#include "memory/arena.h"
|
|
|
|
#include "port/sys_time.h"
|
|
|
|
#include "rocksdb/env.h"
|
|
|
|
#include "util/autovector.h"
|
|
|
|
|
|
|
|
namespace rocksdb {
|
|
|
|
|
|
|
|
class Logger;
|
|
|
|
|
|
|
|
// A class to buffer info log entries and flush them in the end.
|
|
|
|
class LogBuffer {
|
|
|
|
public:
|
|
|
|
// log_level: the log level for all the logs
|
|
|
|
// info_log: logger to write the logs to
|
|
|
|
LogBuffer(const InfoLogLevel log_level, Logger* info_log);
|
|
|
|
|
|
|
|
// Add a log entry to the buffer. Use default max_log_size.
|
|
|
|
// max_log_size indicates maximize log size, including some metadata.
|
|
|
|
void AddLogToBuffer(size_t max_log_size, const char* format, va_list ap);
|
|
|
|
|
Fix data race against logging data structure because of LogBuffer
Summary:
@igor pointed out that there is a potential data race because of the way we use the newly introduced LogBuffer. After "bg_compaction_scheduled_--" or "bg_flush_scheduled_--", they can both become 0. As soon as the lock is released after that, DBImpl's deconstructor can go ahead and deconstruct all the states inside DB, including the info_log object hold in a shared pointer of the options object it keeps. At that point it is not safe anymore to continue using the info logger to write the delayed logs.
With the patch, lock is released temporarily for log buffer to be flushed before "bg_compaction_scheduled_--" or "bg_flush_scheduled_--". In order to make sure we don't miss any pending flush or compaction, a new flag bg_schedule_needed_ is added, which is set to be true if there is a pending flush or compaction but not scheduled because of the max thread limit. If the flag is set to be true, the scheduling function will be called before compaction or flush thread finishes.
Thanks @igor for this finding!
Test Plan: make all check
Reviewers: haobo, igor
Reviewed By: haobo
CC: dhruba, ljin, yhchiang, igor, leveldb
Differential Revision: https://reviews.facebook.net/D16767
11 years ago
|
|
|
size_t IsEmpty() const { return logs_.empty(); }
|
|
|
|
|
|
|
|
// Flush all buffered log to the info log.
|
|
|
|
void FlushBufferToLog();
|
|
|
|
static const size_t kDefaultMaxLogSize = 512;
|
|
|
|
|
|
|
|
private:
|
|
|
|
// One log entry with its timestamp
|
|
|
|
struct BufferedLog {
|
|
|
|
struct timeval now_tv; // Timestamp of the log
|
|
|
|
char message[1]; // Beginning of log message
|
|
|
|
};
|
|
|
|
|
|
|
|
const InfoLogLevel log_level_;
|
|
|
|
Logger* info_log_;
|
|
|
|
Arena arena_;
|
|
|
|
autovector<BufferedLog*> logs_;
|
|
|
|
};
|
|
|
|
|
|
|
|
// Add log to the LogBuffer for a delayed info logging. It can be used when
|
|
|
|
// we want to add some logs inside a mutex.
|
|
|
|
// max_log_size indicates maximize log size, including some metadata.
|
|
|
|
extern void LogToBuffer(LogBuffer* log_buffer, size_t max_log_size,
|
|
|
|
const char* format, ...);
|
|
|
|
// Same as previous function, but with default max log size.
|
|
|
|
extern void LogToBuffer(LogBuffer* log_buffer, const char* format, ...);
|
|
|
|
|
|
|
|
} // namespace rocksdb
|