|
|
|
// Copyright (c) 2016-present, Facebook, Inc. All rights reserved.
|
|
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
|
|
|
|
#pragma once
|
|
|
|
|
|
|
|
#if !defined(OS_WIN)
|
|
|
|
|
|
|
|
#include <string>
|
|
|
|
|
|
|
|
#include "env/fs_remap.h"
|
|
|
|
#include "rocksdb/file_system.h"
|
|
|
|
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
class ChrootFileSystem : public RemapFileSystem {
|
|
|
|
public:
|
|
|
|
ChrootFileSystem(const std::shared_ptr<FileSystem>& base,
|
|
|
|
const std::string& chroot_dir);
|
|
|
|
|
|
|
|
static const char* kClassName() { return "ChrootFS"; }
|
|
|
|
const char* Name() const override { return kClassName(); }
|
|
|
|
|
|
|
|
IOStatus GetTestDirectory(const IOOptions& options, std::string* path,
|
|
|
|
IODebugContext* dbg) override;
|
|
|
|
|
|
|
|
Status PrepareOptions(const ConfigOptions& options) override;
|
|
|
|
|
|
|
|
protected:
|
|
|
|
// Returns status and expanded absolute path including the chroot directory.
|
|
|
|
// Checks whether the provided path breaks out of the chroot. If it returns
|
|
|
|
// non-OK status, the returned path should not be used.
|
|
|
|
std::pair<IOStatus, std::string> EncodePath(const std::string& path) override;
|
|
|
|
|
|
|
|
// Similar to EncodePath() except assumes the basename in the path hasn't been
|
|
|
|
// created yet.
|
|
|
|
std::pair<IOStatus, std::string> EncodePathWithNewBasename(
|
|
|
|
const std::string& path) override;
|
|
|
|
|
|
|
|
private:
|
|
|
|
std::string chroot_dir_;
|
|
|
|
};
|
|
|
|
|
|
|
|
// Returns an Env that translates paths such that the root directory appears to
|
|
|
|
// be chroot_dir. chroot_dir should refer to an existing directory.
|
Make backups openable as read-only DBs (#8142)
Summary:
A current limitation of backups is that you don't know the
exact database state of when the backup was taken. With this new
feature, you can at least inspect the backup's DB state without
restoring it by opening it as a read-only DB.
Rather than add something like OpenAsReadOnlyDB to the BackupEngine API,
which would inhibit opening stackable DB implementations read-only
(if/when their APIs support it), we instead provide a DB name and Env
that can be used to open as a read-only DB.
Possible follow-up work:
* Add a version of GetBackupInfo for a single backup.
* Let CreateNewBackup return the BackupID of the newly-created backup.
Implementation details:
Refactored ChrootFileSystem to split off new base class RemapFileSystem,
which allows more general remapping of files. We use this base class to
implement BackupEngineImpl::RemapSharedFileSystem.
To minimize API impact, I decided to just add these fields `name_for_open`
and `env_for_open` to those set by GetBackupInfo when
include_file_details=true. Creating the RemapSharedFileSystem adds a bit
to the memory consumption, perhaps unnecessarily in some cases, but this
has been mitigated by (a) only initialize the RemapSharedFileSystem
lazily when GetBackupInfo with include_file_details=true is called, and
(b) using the existing `shared_ptr<FileInfo>` objects to hold most of the
mapping data.
To enhance API safety, RemapSharedFileSystem is wrapped by new
ReadOnlyFileSystem which rejects any attempts to write. This uncovered a
couple of places in which DB::OpenForReadOnly would write to the
filesystem, so I fixed these. Added a release note because this affects
logging.
Additional minor refactoring in backupable_db.cc to support the new
functionality.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/8142
Test Plan:
new test (run with ASAN and UBSAN), added to stress test and
ran it for a while with amplified backup_one_in
Reviewed By: ajkr
Differential Revision: D27535408
Pulled By: pdillinger
fbshipit-source-id: 04666d310aa0261ef6b2385c43ca793ce1dfd148
4 years ago
|
|
|
//
|
|
|
|
// This class has not been fully analyzed for providing strong security
|
|
|
|
// guarantees.
|
|
|
|
Env* NewChrootEnv(Env* base_env, const std::string& chroot_dir);
|
|
|
|
std::shared_ptr<FileSystem> NewChrootFileSystem(
|
|
|
|
const std::shared_ptr<FileSystem>& base, const std::string& chroot_dir);
|
|
|
|
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|
|
|
|
|
|
|
|
#endif // !defined(OS_WIN)
|