|
|
|
|
// Copyright (c) 2017-present, Facebook, Inc. All rights reserved.
|
|
|
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
|
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
|
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
|
|
Fix many tests to run with MEM_ENV and ENCRYPTED_ENV; Introduce a MemoryFileSystem class (#7566)
Summary:
This PR does a few things:
1. The MockFileSystem class was split out from the MockEnv. This change would theoretically allow a MockFileSystem to be used by other Environments as well (if we created a means of constructing one). The MockFileSystem implements a FileSystem in its entirety and does not rely on any Wrapper implementation.
2. Make the RocksDB test suite work when MOCK_ENV=1 and ENCRYPTED_ENV=1 are set. To accomplish this, a few things were needed:
- The tests that tried to use the "wrong" environment (Env::Default() instead of env_) were updated
- The MockFileSystem was changed to support the features it was missing or mishandled (such as recursively deleting files in a directory or supporting renaming of a directory).
3. Updated the test framework to have a ROCKSDB_GTEST_SKIP macro. This can be used to flag tests that are skipped. Currently, this defaults to doing nothing (marks the test as SUCCESS) but will mark the tests as SKIPPED when RocksDB is upgraded to a version of gtest that supports this (gtest-1.10).
I have run a full "make check" with MEM_ENV, ENCRYPTED_ENV, both, and neither under both MacOS and RedHat. A few tests were disabled/skipped for the MEM/ENCRYPTED cases. The error_handler_fs_test fails/hangs for MEM_ENV (presumably a timing problem) and I will introduce another PR/issue to track that problem. (I will also push a change to disable those tests soon). There is one more test in DBTest2 that also fails which I need to investigate or skip before this PR is merged.
Theoretically, this PR should also allow the test suite to run against an Env loaded from the registry, though I do not have one to try it with currently.
Finally, once this is accepted, it would be nice if there was a CircleCI job to run these tests on a checkin so this effort does not become stale. I do not know how to do that, so if someone could write that job, it would be appreciated :)
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7566
Reviewed By: zhichao-cao
Differential Revision: D24408980
Pulled By: jay-zhuang
fbshipit-source-id: 911b1554a4d0da06fd51feca0c090a4abdcb4a5f
4 years ago
|
|
|
#pragma once
|
|
|
|
|
#include <gflags/gflags.h>
|
|
|
|
|
|
|
|
|
|
#include <functional>
|
|
|
|
|
|
|
|
|
|
#ifndef GFLAGS_NAMESPACE
|
|
|
|
|
// in case it's not defined in old versions, that's probably because it was
|
|
|
|
|
// still google by default.
|
|
|
|
|
#define GFLAGS_NAMESPACE google
|
|
|
|
|
#endif
|
|
|
|
|
|
|
|
|
|
#ifndef DEFINE_uint32
|
|
|
|
|
// DEFINE_uint32 does not appear in older versions of gflags. This should be
|
|
|
|
|
// a sane definition for those versions.
|
|
|
|
|
#include <cstdint>
|
|
|
|
|
#define DEFINE_uint32(name, val, txt) \
|
|
|
|
|
namespace gflags_compat { \
|
|
|
|
|
DEFINE_int32(name, val, txt); \
|
|
|
|
|
} \
|
|
|
|
|
std::reference_wrapper<uint32_t> FLAGS_##name = \
|
|
|
|
|
std::ref(*reinterpret_cast<uint32_t *>(&gflags_compat::FLAGS_##name));
|
|
|
|
|
|
|
|
|
|
#define DECLARE_uint32(name) \
|
|
|
|
|
extern std::reference_wrapper<uint32_t> FLAGS_##name;
|
|
|
|
|
#endif // !DEFINE_uint32
|
