|
|
|
// Copyright (c) 2014, Facebook, Inc. All rights reserved.
|
|
|
|
// This source code is licensed under the BSD-style license found in the
|
|
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
|
|
|
|
|
|
package org.rocksdb;
|
|
|
|
|
|
|
|
/**
|
|
|
|
* RocksObject is the base-class of all RocksDB classes that has a pointer to
|
|
|
|
* some c++ rocksdb object.
|
|
|
|
*
|
|
|
|
* RocksObject has dispose() function, which releases its associated c++ resource.
|
|
|
|
* This function can be either called manually, or being called automatically
|
|
|
|
* during the regular Java GC process. However, since Java may wrongly assume a
|
|
|
|
* RocksObject only contains a long member variable and think it is small in size,
|
|
|
|
* Java may give RocksObject low priority in the GC process. For this, it is
|
|
|
|
* suggested to call dispose() manually. However, it is safe to let RocksObject go
|
|
|
|
* out-of-scope without manually calling dispose() as dispose() will be called
|
|
|
|
* in the finalizer during the regular GC process.
|
|
|
|
*/
|
|
|
|
public abstract class RocksObject {
|
|
|
|
protected RocksObject() {
|
|
|
|
nativeHandle_ = 0;
|
[Java] Generalize dis-own native handle and refine dispose framework.
Summary:
1. Move disOwnNativeHandle() function from RocksDB to RocksObject
to allow other RocksObject to use disOwnNativeHandle() when its
ownership of native handle has been transferred.
2. RocksObject now has an abstract implementation of dispose(),
which does the following two things. First, it checks whether
both isOwningNativeHandle() and isInitialized() return true.
If so, it will call the protected abstract function dispose0(),
which all the subclasses of RocksObject should implement. Second,
it sets nativeHandle_ = 0. This redesign ensure all subclasses
of RocksObject have the same dispose behavior.
3. All subclasses of RocksObject now should implement dispose0()
instead of dispose(), and dispose0() will be called only when
isInitialized() returns true.
Test Plan:
make rocksdbjava
make jtest
Reviewers: dhruba, sdong, ankgup87, rsumbaly, swapnilghike, zzbennett, haobo
Reviewed By: haobo
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D18801
11 years ago
|
|
|
owningHandle_ = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Release the c++ object manually pointed by the native handle.
|
|
|
|
*
|
|
|
|
* Note that dispose() will also be called during the GC process
|
|
|
|
* if it was not called before its RocksObject went out-of-scope.
|
|
|
|
* However, since Java may wrongly wrongly assume those objects are
|
|
|
|
* small in that they seems to only hold a long variable. As a result,
|
|
|
|
* they might have low priority in the GC process. To prevent this,
|
|
|
|
* it is suggested to call dispose() manually.
|
[Java] Generalize dis-own native handle and refine dispose framework.
Summary:
1. Move disOwnNativeHandle() function from RocksDB to RocksObject
to allow other RocksObject to use disOwnNativeHandle() when its
ownership of native handle has been transferred.
2. RocksObject now has an abstract implementation of dispose(),
which does the following two things. First, it checks whether
both isOwningNativeHandle() and isInitialized() return true.
If so, it will call the protected abstract function dispose0(),
which all the subclasses of RocksObject should implement. Second,
it sets nativeHandle_ = 0. This redesign ensure all subclasses
of RocksObject have the same dispose behavior.
3. All subclasses of RocksObject now should implement dispose0()
instead of dispose(), and dispose0() will be called only when
isInitialized() returns true.
Test Plan:
make rocksdbjava
make jtest
Reviewers: dhruba, sdong, ankgup87, rsumbaly, swapnilghike, zzbennett, haobo
Reviewed By: haobo
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D18801
11 years ago
|
|
|
*
|
|
|
|
* Note that once an instance of RocksObject has been disposed,
|
|
|
|
* calling its function will lead undefined behavior.
|
|
|
|
*/
|
[Java] Generalize dis-own native handle and refine dispose framework.
Summary:
1. Move disOwnNativeHandle() function from RocksDB to RocksObject
to allow other RocksObject to use disOwnNativeHandle() when its
ownership of native handle has been transferred.
2. RocksObject now has an abstract implementation of dispose(),
which does the following two things. First, it checks whether
both isOwningNativeHandle() and isInitialized() return true.
If so, it will call the protected abstract function dispose0(),
which all the subclasses of RocksObject should implement. Second,
it sets nativeHandle_ = 0. This redesign ensure all subclasses
of RocksObject have the same dispose behavior.
3. All subclasses of RocksObject now should implement dispose0()
instead of dispose(), and dispose0() will be called only when
isInitialized() returns true.
Test Plan:
make rocksdbjava
make jtest
Reviewers: dhruba, sdong, ankgup87, rsumbaly, swapnilghike, zzbennett, haobo
Reviewed By: haobo
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D18801
11 years ago
|
|
|
public final synchronized void dispose() {
|
|
|
|
if (isOwningNativeHandle() && isInitialized()) {
|
|
|
|
disposeInternal();
|
|
|
|
}
|
|
|
|
nativeHandle_ = 0;
|
|
|
|
disOwnNativeHandle();
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* The helper function of dispose() which all subclasses of RocksObject
|
|
|
|
* must implement to release their associated C++ resource.
|
|
|
|
*/
|
|
|
|
protected abstract void disposeInternal();
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Revoke ownership of the native object.
|
|
|
|
*
|
|
|
|
* This will prevent the object from attempting to delete the underlying
|
|
|
|
* native object in its finalizer. This must be used when another object
|
|
|
|
* takes over ownership of the native object or both will attempt to delete
|
|
|
|
* the underlying object when garbage collected.
|
|
|
|
*
|
|
|
|
* When disOwnNativeHandle() is called, dispose() will simply set nativeHandle_
|
[Java] Generalize dis-own native handle and refine dispose framework.
Summary:
1. Move disOwnNativeHandle() function from RocksDB to RocksObject
to allow other RocksObject to use disOwnNativeHandle() when its
ownership of native handle has been transferred.
2. RocksObject now has an abstract implementation of dispose(),
which does the following two things. First, it checks whether
both isOwningNativeHandle() and isInitialized() return true.
If so, it will call the protected abstract function dispose0(),
which all the subclasses of RocksObject should implement. Second,
it sets nativeHandle_ = 0. This redesign ensure all subclasses
of RocksObject have the same dispose behavior.
3. All subclasses of RocksObject now should implement dispose0()
instead of dispose(), and dispose0() will be called only when
isInitialized() returns true.
Test Plan:
make rocksdbjava
make jtest
Reviewers: dhruba, sdong, ankgup87, rsumbaly, swapnilghike, zzbennett, haobo
Reviewed By: haobo
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D18801
11 years ago
|
|
|
* to 0 without releasing its associated C++ resource. As a result,
|
|
|
|
* incorrectly use this function may cause memory leak, and this function call
|
|
|
|
* will not affect the return value of isInitialized().
|
|
|
|
*
|
|
|
|
* @see dispose()
|
|
|
|
* @see isInitialized()
|
[Java] Generalize dis-own native handle and refine dispose framework.
Summary:
1. Move disOwnNativeHandle() function from RocksDB to RocksObject
to allow other RocksObject to use disOwnNativeHandle() when its
ownership of native handle has been transferred.
2. RocksObject now has an abstract implementation of dispose(),
which does the following two things. First, it checks whether
both isOwningNativeHandle() and isInitialized() return true.
If so, it will call the protected abstract function dispose0(),
which all the subclasses of RocksObject should implement. Second,
it sets nativeHandle_ = 0. This redesign ensure all subclasses
of RocksObject have the same dispose behavior.
3. All subclasses of RocksObject now should implement dispose0()
instead of dispose(), and dispose0() will be called only when
isInitialized() returns true.
Test Plan:
make rocksdbjava
make jtest
Reviewers: dhruba, sdong, ankgup87, rsumbaly, swapnilghike, zzbennett, haobo
Reviewed By: haobo
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D18801
11 years ago
|
|
|
*/
|
|
|
|
protected void disOwnNativeHandle() {
|
|
|
|
owningHandle_ = false;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Returns true if the current RocksObject is responsable to release its
|
|
|
|
* native handle.
|
|
|
|
*
|
|
|
|
* @return true if the current RocksObject is responsible to release its
|
|
|
|
* native handle.
|
|
|
|
*
|
|
|
|
* @see disOwnNativeHandle()
|
|
|
|
* @see dispose()
|
|
|
|
*/
|
[Java] Generalize dis-own native handle and refine dispose framework.
Summary:
1. Move disOwnNativeHandle() function from RocksDB to RocksObject
to allow other RocksObject to use disOwnNativeHandle() when its
ownership of native handle has been transferred.
2. RocksObject now has an abstract implementation of dispose(),
which does the following two things. First, it checks whether
both isOwningNativeHandle() and isInitialized() return true.
If so, it will call the protected abstract function dispose0(),
which all the subclasses of RocksObject should implement. Second,
it sets nativeHandle_ = 0. This redesign ensure all subclasses
of RocksObject have the same dispose behavior.
3. All subclasses of RocksObject now should implement dispose0()
instead of dispose(), and dispose0() will be called only when
isInitialized() returns true.
Test Plan:
make rocksdbjava
make jtest
Reviewers: dhruba, sdong, ankgup87, rsumbaly, swapnilghike, zzbennett, haobo
Reviewed By: haobo
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D18801
11 years ago
|
|
|
protected boolean isOwningNativeHandle() {
|
|
|
|
return owningHandle_;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Returns true if the associated native handle has been initialized.
|
|
|
|
*
|
|
|
|
* @return true if the associated native handle has been initialized.
|
|
|
|
*
|
|
|
|
* @see dispose()
|
|
|
|
*/
|
|
|
|
protected boolean isInitialized() {
|
|
|
|
return (nativeHandle_ != 0);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Simply calls dispose() and release its c++ resource if it has not
|
|
|
|
* yet released.
|
|
|
|
*/
|
|
|
|
@Override protected void finalize() {
|
|
|
|
dispose();
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* A long variable holding c++ pointer pointing to some RocksDB C++ object.
|
|
|
|
*/
|
|
|
|
protected long nativeHandle_;
|
|
|
|
|
|
|
|
/**
|
|
|
|
* A flag indicating whether the current RocksObject is responsible to
|
|
|
|
* release the c++ object stored in its nativeHandle_.
|
|
|
|
*/
|
[Java] Generalize dis-own native handle and refine dispose framework.
Summary:
1. Move disOwnNativeHandle() function from RocksDB to RocksObject
to allow other RocksObject to use disOwnNativeHandle() when its
ownership of native handle has been transferred.
2. RocksObject now has an abstract implementation of dispose(),
which does the following two things. First, it checks whether
both isOwningNativeHandle() and isInitialized() return true.
If so, it will call the protected abstract function dispose0(),
which all the subclasses of RocksObject should implement. Second,
it sets nativeHandle_ = 0. This redesign ensure all subclasses
of RocksObject have the same dispose behavior.
3. All subclasses of RocksObject now should implement dispose0()
instead of dispose(), and dispose0() will be called only when
isInitialized() returns true.
Test Plan:
make rocksdbjava
make jtest
Reviewers: dhruba, sdong, ankgup87, rsumbaly, swapnilghike, zzbennett, haobo
Reviewed By: haobo
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D18801
11 years ago
|
|
|
private boolean owningHandle_;
|
|
|
|
}
|