From 00e68e7a30f1488f86e72bf5990326e6678c6a86 Mon Sep 17 00:00:00 2001 From: sdong Date: Thu, 14 Jul 2022 22:24:02 -0700 Subject: [PATCH] DB::PutEntity() shouldn't be defined as =0 (#10364) Summary: DB::PutEntity() is defined as 0, but it is actually implemented in db/db_impl/db_impl_write.cc. It is incorrect, and might cause problems when users implement class DB themselves. Pull Request resolved: https://github.com/facebook/rocksdb/pull/10364 Test Plan: See existing tests pass Reviewed By: riversand963 Differential Revision: D37874886 fbshipit-source-id: b81713ddb707720b52d57a15de56a59414c24f66 --- include/rocksdb/db.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/rocksdb/db.h b/include/rocksdb/db.h index 7f8c7a57e..8e72140d0 100644 --- a/include/rocksdb/db.h +++ b/include/rocksdb/db.h @@ -410,7 +410,7 @@ class DB { // UNDER CONSTRUCTION -- DO NOT USE virtual Status PutEntity(const WriteOptions& options, ColumnFamilyHandle* column_family, const Slice& key, - const WideColumns& columns) = 0; + const WideColumns& columns); // Remove the database entry (if any) for "key". Returns OK on // success, and a non-OK status on error. It is not an error if "key"