BlobDB in crash test hitting assertion (#10249)

Summary:
This task is to fix assertion failures during the crash test runs. The cache entry size might not match value size because value size can include the on-disk (possibly compressed) size. Therefore, we removed the assertions.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/10249

Reviewed By: ltamasi

Differential Revision: D37407576

Pulled By: gangliao

fbshipit-source-id: 577559f267c5b2437bcd0631cd0efabb6dde3b69
main
Gang Liao 3 years ago committed by Facebook GitHub Bot
parent 725df120e9
commit 052666aed5
  1. 2
      db/blob/blob_source.cc

@ -99,7 +99,6 @@ Status BlobSource::GetBlob(const ReadOptions& read_options,
Slice key = cache_key.AsSlice();
s = GetBlobFromCache(key, &blob_entry);
if (s.ok() && blob_entry.GetValue()) {
assert(blob_entry.GetValue()->size() == value_size);
if (bytes_read) {
*bytes_read = value_size;
}
@ -192,7 +191,6 @@ void BlobSource::MultiGetBlob(
s = GetBlobFromCache(key, &blob_entry);
if (s.ok() && blob_entry.GetValue()) {
assert(statuses[i]);
assert(blob_entry.GetValue()->size() == value_sizes[i]);
*statuses[i] = s;
blobs[i]->PinSelf(*blob_entry.GetValue());

Loading…
Cancel
Save