From 0d2172f12800457ebb1d0ef36ba3ca6e0c218d0c Mon Sep 17 00:00:00 2001 From: Levi Tamasi Date: Fri, 13 Dec 2019 15:52:38 -0800 Subject: [PATCH] Make it possible to enable periodic compactions for BlobDB (#6172) Summary: Periodic compactions ensure that even SSTs that do not get picked up otherwise eventually go through compaction; used in conjunction with BlobDB's garbage collection, they enable BlobDB to reclaim space when old blob files are used by such straggling SSTs. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6172 Test Plan: Ran `make check` and used the BlobDB mode of `db_bench`. Differential Revision: D19045045 Pulled By: ltamasi fbshipit-source-id: 04636ecc4b6cfe8d495bf656faa65d54a5eb1a93 --- utilities/blob_db/blob_db_impl.cc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/utilities/blob_db/blob_db_impl.cc b/utilities/blob_db/blob_db_impl.cc index bb597f305..de5aebc27 100644 --- a/utilities/blob_db/blob_db_impl.cc +++ b/utilities/blob_db/blob_db_impl.cc @@ -148,10 +148,6 @@ Status BlobDBImpl::Open(std::vector* handles) { "Garbage collection cutoff must be in the interval [0.0, 1.0]"); } - // BlobDB does not support Periodic Compactions. So disable periodic - // compactions irrespective of the user set value. - cf_options_.periodic_compaction_seconds = 0; - // Temporarily disable compactions in the base DB during open; save the user // defined value beforehand so we can restore it once BlobDB is initialized. // Note: this is only needed if garbage collection is enabled.