From 0e926b84fd8fee6d8a29b4c9e6469c848b198867 Mon Sep 17 00:00:00 2001 From: Anirban Rahut Date: Fri, 21 Oct 2016 14:57:44 -0700 Subject: [PATCH] Passing DISABLE_JEMALLOC=1 to valgrind_check if run locally Summary: Valgrind does not work well with JEMALLOC. If you run a simple make valgrind_check, you will see lots of issues and crashes. When precommit runs, this is taken care of. Here we make sure valgrind_check is passed in DISABLE_JEMALLOC=1 Test Plan: Ran local valgrind_test and noticed the difference Reviewers: IslamAbdelRahman Reviewed By: IslamAbdelRahman Subscribers: andrewkr, dhruba Differential Revision: https://reviews.facebook.net/D65379 --- Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile b/Makefile index 5a71f457c..9d0c14931 100644 --- a/Makefile +++ b/Makefile @@ -723,6 +723,9 @@ ubsan_crash_test: COMPILE_WITH_UBSAN=1 $(MAKE) crash_test $(MAKE) clean +valgrind_test: + DISABLE_JEMALLOC=1 $(MAKE) valgrind_check + valgrind_check: $(TESTS) $(MAKE) DRIVER="$(VALGRIND_VER) $(VALGRIND_OPTS)" gen_parallel_tests $(AM_V_GEN)if test "$(J)" != 1 \