From 0f487cc35f76dafa1dd6707ceb8665d9eac72abb Mon Sep 17 00:00:00 2001 From: sdong Date: Mon, 20 Jul 2020 14:59:49 -0700 Subject: [PATCH] Exclude two tests in CircleCI TSAN tests (#7152) Summary: Two TSAN tests occaionaly fail. Exclude them for now: [ RUN ] DeleteFileTest.BackgroundPurgeCFDropTest db/deletefile_test.cc:122: Failure Expected equality of these values: required_manifest Which is: 1 manifest_cnt Which is: 2 [ RUN ] FormatLatest/ColumnFamilyTest.FlushCloseWALFiles/0 db/column_family_test.cc:3004: Failure Expected equality of these values: 2 env.num_open_wal_file_.load() Which is: 1 Pull Request resolved: https://github.com/facebook/rocksdb/pull/7152 Test Plan: Watch CircleCI restuls Reviewed By: ajkr Differential Revision: D22632285 fbshipit-source-id: 29fa348e8be917be0237c74812a8b0b04978e84e --- .circleci/config.yml | 2 +- Makefile | 2 ++ TARGETS | 4 ++-- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 67ec71d0f..a757e516f 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -115,7 +115,7 @@ jobs: - run: echo "deb http://apt.llvm.org/xenial/ llvm-toolchain-xenial-10 main" | sudo tee -a /etc/apt/sources.list - run: echo "deb-src http://apt.llvm.org/xenial/ llvm-toolchain-xenial-10 main" | sudo tee -a /etc/apt/sources.list - run: sudo apt-get update -y && sudo apt-get install -y clang-10 libgflags-dev - - run: SKIP_FORMAT_BUCK_CHECKS=1 COMPILE_WITH_TSAN=1 CC=clang-10 CXX=clang++-10 ROCKSDB_DISABLE_ALIGNED_NEW=1 USE_CLANG=1 PRINT_PARALLEL_OUTPUTS=1 EXCLUDE_TESTS_REGEX="TransactionStressTest|SnapshotConcurrentAccess|SeqAdvanceConcurrent|DeadlockStress|MultiThreadedDBTest.MultiThreaded|WriteUnpreparedStressTest.ReadYourOwnWriteStress|DBAsBaseDB/TransactionStressTest" GTEST_THROW_ON_FAILURE=0 GTEST_OUTPUT="xml:/tmp/test-results/" make V=1 -j32 check | .circleci/cat_ignore_eagain # aligned new doesn't work for reason we haven't figured out. + - run: SKIP_FORMAT_BUCK_CHECKS=1 COMPILE_WITH_TSAN=1 CC=clang-10 CXX=clang++-10 ROCKSDB_DISABLE_ALIGNED_NEW=1 USE_CLANG=1 PRINT_PARALLEL_OUTPUTS=1 EXCLUDE_TESTS_REGEX="TransactionStressTest|SnapshotConcurrentAccess|SeqAdvanceConcurrent|DeadlockStress|MultiThreadedDBTest.MultiThreaded|WriteUnpreparedStressTest.ReadYourOwnWriteStress|DBAsBaseDB/TransactionStressTest|FlushCloseWALFiles|BackgroundPurgeCFDropTest" GTEST_THROW_ON_FAILURE=0 GTEST_OUTPUT="xml:/tmp/test-results/" make V=1 -j32 check | .circleci/cat_ignore_eagain # aligned new doesn't work for reason we haven't figured out. Exclude FlushCloseWALFiles and BackgroundPurgeCFDropTest for occasional failures. - store_test_results: path: /tmp/test-results diff --git a/Makefile b/Makefile index 2aa816192..cd3792a6c 100644 --- a/Makefile +++ b/Makefile @@ -517,8 +517,10 @@ PARALLEL_TEST = \ db_merge_operator_test \ db_sst_test \ db_test \ + db_test2 \ db_universal_compaction_test \ db_wal_test \ + column_family_test \ external_sst_file_test \ import_column_family_test \ fault_injection_test \ diff --git a/TARGETS b/TARGETS index 6db4905d7..19a9c4651 100644 --- a/TARGETS +++ b/TARGETS @@ -650,7 +650,7 @@ ROCKS_TESTS = [ [ "column_family_test", "db/column_family_test.cc", - "serial", + "parallel", [], [], ], @@ -944,7 +944,7 @@ ROCKS_TESTS = [ [ "db_test2", "db/db_test2.cc", - "serial", + "parallel", [], [], ],