From 0fbb3facc020a38520710b409d628384f8f29f0d Mon Sep 17 00:00:00 2001 From: Raghav Pisolkar Date: Fri, 5 Sep 2014 00:47:54 -0700 Subject: [PATCH] fixed memory leak in unit test DBIteratorBoundTest Summary: fixed memory leak in unit test DBIteratorBoundTest Test Plan: ran valgrind test on my unit test Reviewers: sdong Differential Revision: https://reviews.facebook.net/D22911 --- db/db_test.cc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/db/db_test.cc b/db/db_test.cc index 5bd781696..570af31a5 100644 --- a/db/db_test.cc +++ b/db/db_test.cc @@ -7791,7 +7791,8 @@ TEST(DBTest, DBIteratorBoundTest) { { ReadOptions ro; // iterate_upper_bound points beyond the last expected entry - ro.iterate_upper_bound = new Slice("foo2"); + Slice prefix("foo2"); + ro.iterate_upper_bound = &prefix; std::unique_ptr iter(db_->NewIterator(ro)); @@ -7823,7 +7824,8 @@ TEST(DBTest, DBIteratorBoundTest) { // This should be an error { ReadOptions ro; - ro.iterate_upper_bound = new Slice("g1"); + Slice prefix("g1"); + ro.iterate_upper_bound = &prefix; std::unique_ptr iter(db_->NewIterator(ro)); @@ -7868,7 +7870,8 @@ TEST(DBTest, DBIteratorBoundTest) { ASSERT_EQ(static_cast(perf_context.internal_delete_skipped_count), 2); // now testing with iterate_bound - ro.iterate_upper_bound = new Slice("c"); + Slice prefix("c"); + ro.iterate_upper_bound = &prefix; iter.reset(db_->NewIterator(ro));