From 12966ec1bb22fecf9f43099b13626953d5d3e661 Mon Sep 17 00:00:00 2001
From: Igor Canadi <icanadi@fb.com>
Date: Fri, 28 Feb 2014 12:22:45 -0800
Subject: [PATCH] Fix LogAndApply() group commit

---
 db/version_set.cc | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/db/version_set.cc b/db/version_set.cc
index 44d8db983..9a5be3691 100644
--- a/db/version_set.cc
+++ b/db/version_set.cc
@@ -1580,9 +1580,9 @@ Status VersionSet::LogAndApply(ColumnFamilyData* column_family_data,
 
     // Write new record to MANIFEST log
     if (s.ok()) {
-      std::string record;
-      for (unsigned int i = 0; i < batch_edits.size(); i++) {
-        batch_edits[i]->EncodeTo(&record);
+      for (auto& e : batch_edits) {
+        std::string record;
+        e->EncodeTo(&record);
         s = descriptor_log_->AddRecord(record);
         if (!s.ok()) {
           break;
@@ -1601,7 +1601,16 @@ Status VersionSet::LogAndApply(ColumnFamilyData* column_family_data,
       }
       if (!s.ok()) {
         Log(options_->info_log, "MANIFEST write: %s\n", s.ToString().c_str());
-        if (ManifestContains(record)) {
+        bool all_records_in = true;
+        for (auto& e : batch_edits) {
+          std::string record;
+          e->EncodeTo(&record);
+          if (!ManifestContains(record)) {
+            all_records_in = false;
+            break;
+          }
+        }
+        if (all_records_in) {
           Log(options_->info_log,
               "MANIFEST contains log record despite error; advancing to new "
               "version to prevent mismatch between in-memory and logged state"