From 186c7eedb0d35a16bcfcab00cfb3814c8294fdfa Mon Sep 17 00:00:00 2001 From: Andrew Kryczka Date: Tue, 7 Feb 2017 11:33:14 -0800 Subject: [PATCH] Remove incorrect statistics warning Summary: statistics are always concurrently updated regardless of whether a single instance or multiple instances are used. remove the warning since it's unnecessarily preventing people from sharing stats objects across rocksdb instances. replace #1819 which was having some problem with our internal tools. Closes https://github.com/facebook/rocksdb/pull/1826 Differential Revision: D4495970 Pulled By: ajkr fbshipit-source-id: 6601f61 --- include/rocksdb/options.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/rocksdb/options.h b/include/rocksdb/options.h index 7caa8a6ea..5ab211aed 100644 --- a/include/rocksdb/options.h +++ b/include/rocksdb/options.h @@ -946,8 +946,6 @@ struct DBOptions { uint64_t max_total_wal_size = 0; // If non-null, then we should collect metrics about database operations - // Statistics objects should not be shared between DB instances as - // it does not use any locks to prevent concurrent updates. std::shared_ptr statistics = nullptr; // If true, then the contents of manifest and data files are not synced