From 1b7ea8ce81d2848f1bf7c428023b6c2f9fa56a24 Mon Sep 17 00:00:00 2001 From: Igor Canadi Date: Tue, 15 Sep 2015 18:10:36 -0700 Subject: [PATCH] Skipped tests shouldn't be failures Summary: If we skip a test, we shouldn't mark `make check` as failure. This fixes travis CI test. Test Plan: Travis CI Reviewers: noetzli, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D47031 --- db/prefix_test.cc | 4 ++-- util/bloom_test.cc | 4 ++-- util/dynamic_bloom_test.cc | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/db/prefix_test.cc b/db/prefix_test.cc index e2dfba12e..d095d444f 100644 --- a/db/prefix_test.cc +++ b/db/prefix_test.cc @@ -8,8 +8,8 @@ #ifndef GFLAGS #include int main() { - fprintf(stderr, "Please install gflags to run rocksdb tools\n"); - return 1; + fprintf(stderr, "Please install gflags to run this test... Skipping...\n"); + return 0; } #else diff --git a/util/bloom_test.cc b/util/bloom_test.cc index 237bf7d87..aac5b3978 100644 --- a/util/bloom_test.cc +++ b/util/bloom_test.cc @@ -10,8 +10,8 @@ #ifndef GFLAGS #include int main() { - fprintf(stderr, "Please install gflags to run rocksdb tools\n"); - return 1; + fprintf(stderr, "Please install gflags to run this test... Skipping...\n"); + return 0; } #else diff --git a/util/dynamic_bloom_test.cc b/util/dynamic_bloom_test.cc index fb10d0974..cb3836661 100644 --- a/util/dynamic_bloom_test.cc +++ b/util/dynamic_bloom_test.cc @@ -6,8 +6,8 @@ #ifndef GFLAGS #include int main() { - fprintf(stderr, "Please install gflags to run rocksdb tools\n"); - return 1; + fprintf(stderr, "Please install gflags to run this test... Skipping...\n"); + return 0; } #else