From 22dcaaff30917e3922ad29254529c1e20031c1b0 Mon Sep 17 00:00:00 2001 From: Islam AbdelRahman Date: Fri, 7 Aug 2015 15:37:56 -0700 Subject: [PATCH] More accurate time measurement for delete_scheduler_test Summary: Start measuring time spent before BackgroundEmptyTrash starts Test Plan: delete_scheduler_test Reviewers: yhchiang, sdong Reviewed By: sdong Subscribers: dhruba Differential Revision: https://reviews.facebook.net/D43857 --- util/delete_scheduler_test.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/util/delete_scheduler_test.cc b/util/delete_scheduler_test.cc index 1ef634280..760fd43eb 100644 --- a/util/delete_scheduler_test.cc +++ b/util/delete_scheduler_test.cc @@ -131,8 +131,8 @@ TEST_F(DeleteSchedulerTest, BasicRateLimiting) { } ASSERT_EQ(CountFilesInDir(dummy_files_dir_), 0); - TEST_SYNC_POINT("DeleteSchedulerTest::BasicRateLimiting:1"); uint64_t delete_start_time = env_->NowMicros(); + TEST_SYNC_POINT("DeleteSchedulerTest::BasicRateLimiting:1"); WaitForEmptyTrash(); uint64_t time_spent_deleting = env_->NowMicros() - delete_start_time; @@ -211,9 +211,8 @@ TEST_F(DeleteSchedulerTest, RateLimitingMultiThreaded) { threads[i].join(); } - TEST_SYNC_POINT("DeleteSchedulerTest::RateLimitingMultiThreaded:1"); - uint64_t delete_start_time = env_->NowMicros(); + TEST_SYNC_POINT("DeleteSchedulerTest::RateLimitingMultiThreaded:1"); WaitForEmptyTrash(); uint64_t time_spent_deleting = env_->NowMicros() - delete_start_time;