From 25fbd9a99666e5e5ecd842bdfd7154f8d9839485 Mon Sep 17 00:00:00 2001 From: Maysam Yabandeh Date: Thu, 2 Nov 2017 11:06:10 -0700 Subject: [PATCH] Remove the experimental notes about partitioning Summary: This patch will remove the existing comments that declare partitioning indexes and filters as experimental. Closes https://github.com/facebook/rocksdb/pull/3115 Differential Revision: D6222227 Pulled By: maysamyabandeh fbshipit-source-id: 6179ec43b22c518494051b674d91c9e1b54d4ac0 --- include/rocksdb/table.h | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/include/rocksdb/table.h b/include/rocksdb/table.h index 1b4c0ced9..d3cf74d1e 100644 --- a/include/rocksdb/table.h +++ b/include/rocksdb/table.h @@ -87,9 +87,6 @@ struct BlockBasedTableOptions { // `Options.prefix_extractor` is provided. kHashSearch, - // TODO(myabandeh): this feature is in experimental phase and shall not be - // used in production; either remove the feature or remove this comment if - // it is ready to be used in production. // A two-level index implementation. Both levels are binary search indexes. kTwoLevelIndexSearch, }; @@ -158,10 +155,8 @@ struct BlockBasedTableOptions { // Note: currently this option requires kTwoLevelIndexSearch to be set as // well. // TODO(myabandeh): remove the note above once the limitation is lifted - // TODO(myabandeh): this feature is in experimental phase and shall not be - // used in production; either remove the feature or remove this comment if - // it is ready to be used in production. - // Use partitioned full filters for each SST file + // Use partitioned full filters for each SST file. This option is + // incompatibile with block-based filters. bool partition_filters = false; // Use delta encoding to compress keys in blocks.