From 267b9b109176f51e59604233d6bef5293278f2a1 Mon Sep 17 00:00:00 2001 From: Yanqin Jin Date: Wed, 5 Jun 2019 13:56:46 -0700 Subject: [PATCH] Disable dynamic extension support by default for CMake (#5419) Summary: We have users reporting linking error while building RocksDB using CMake, and we do not enable dynamic extension feature for them. The fix is to add `-DROCKSDB_NO_DYNAMIC_EXTENSION` to CMake by default. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5419 Differential Revision: D15676792 Pulled By: riversand963 fbshipit-source-id: d45aaacfc64ea61646fd7329c352cd760145baf3 --- CMakeLists.txt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 7cb4cc7a8..354697b05 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -332,6 +332,10 @@ if(DISABLE_STALL_NOTIF) add_definitions(-DROCKSDB_DISABLE_STALL_NOTIFICATION) endif() +option(WITH_DYNAMIC_EXTENSION "build with dynamic extension support" OFF) +if(NOT WITH_DYNAMIC_EXTENSION) + add_definitions(-DROCKSDB_NO_DYNAMIC_EXTENSION) +endif() if(DEFINED USE_RTTI) if(USE_RTTI) @@ -488,7 +492,7 @@ set(SOURCES db/compacted_db_impl.cc db/compaction/compaction.cc db/compaction/compaction_iterator.cc - db/compaction/compaction_picker.cc + db/compaction/compaction_picker.cc db/compaction/compaction_job.cc db/compaction/compaction_picker_fifo.cc db/compaction/compaction_picker_level.cc