From 2b2994c8db34db051e496413f4582855dbc3d200 Mon Sep 17 00:00:00 2001 From: Peter Dillinger Date: Wed, 7 Jun 2023 13:21:31 -0700 Subject: [PATCH] Fix old comment about HyperClockCache and SecondaryCache (#11517) Summary: Support was added in 8.1.0 Pull Request resolved: https://github.com/facebook/rocksdb/pull/11517 Test Plan: comments only Reviewed By: anand1976 Differential Revision: D46489929 Pulled By: pdillinger fbshipit-source-id: 4fd30078389065c9ec225bf55b6773f1641f0646 --- include/rocksdb/cache.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/rocksdb/cache.h b/include/rocksdb/cache.h index 12c2d424f..2708e752d 100644 --- a/include/rocksdb/cache.h +++ b/include/rocksdb/cache.h @@ -376,7 +376,6 @@ inline std::shared_ptr NewCompressedSecondaryCache( // * Requires an extra tuning parameter: see estimated_entry_charge below. // Similarly, substantially changing the capacity with SetCapacity could // harm efficiency. -// * SecondaryCache is not yet supported. // * Cache priorities are less aggressively enforced, which could cause // cache dilution from long range scans (unless they use fill_cache=false). // * Can be worse for small caches, because if almost all of a cache shard is