From 2e51b33de9979673e3d0e8f632ee9e73dbe04bd6 Mon Sep 17 00:00:00 2001 From: Andreas Hindborg Date: Tue, 21 Dec 2021 12:26:01 -0800 Subject: [PATCH] Fix a bug that occur when plugin pkg-config requirements are empty (#9238) Summary: Fix a bug introduced by https://github.com/facebook/rocksdb/issues/9198. The bug is triggered when a plugin does not provide any pkg-config requirements. Pull Request resolved: https://github.com/facebook/rocksdb/pull/9238 Reviewed By: riversand963 Differential Revision: D32771406 Pulled By: ajkr fbshipit-source-id: 79301871a8bf4e624d5e5eb9d219d7f13948c64d --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 86df4644f..6b59ffcbe 100644 --- a/Makefile +++ b/Makefile @@ -253,7 +253,7 @@ ROCKSDB_PLUGIN_PKGCONFIG_REQUIRES = $(foreach plugin, $(ROCKSDB_PLUGINS), $($(pl PLATFORM_LDFLAGS += $(foreach plugin, $(ROCKSDB_PLUGINS), $($(plugin)_LDFLAGS)) CXXFLAGS += $(foreach plugin, $(ROCKSDB_PLUGINS), $($(plugin)_CXXFLAGS)) -ifneq ($(ROCKSDB_PLUGIN_PKGCONFIG_REQUIRES),) +ifneq ($(strip $(ROCKSDB_PLUGIN_PKGCONFIG_REQUIRES)),) LDFLAGS := $(LDFLAGS) $(shell pkg-config --libs $(ROCKSDB_PLUGIN_PKGCONFIG_REQUIRES)) ifneq ($(.SHELLSTATUS),0) $(error pkg-config failed)