From 34723b4c4ae8871b4c167923a96f7594f675292a Mon Sep 17 00:00:00 2001 From: Dhruba Borthakur Date: Thu, 4 Aug 2016 16:02:50 -0700 Subject: [PATCH] Cleanup unused variable pending_fsync_. Summary: Cleanup unused variable pending_fsync_. Test Plan: make check Subscribers: leveldb, andrewkr, dhruba Differential Revision: https://reviews.facebook.net/D61581 --- util/file_reader_writer.cc | 4 ---- util/file_reader_writer.h | 2 -- 2 files changed, 6 deletions(-) diff --git a/util/file_reader_writer.cc b/util/file_reader_writer.cc index b12263610..662648f85 100644 --- a/util/file_reader_writer.cc +++ b/util/file_reader_writer.cc @@ -51,7 +51,6 @@ Status WritableFileWriter::Append(const Slice& data) { size_t left = data.size(); Status s; pending_sync_ = true; - pending_fsync_ = true; TEST_KILL_RANDOM("WritableFileWriter::Append:0", rocksdb_kill_odds * REDUCE_ODDS2); @@ -218,9 +217,6 @@ Status WritableFileWriter::Sync(bool use_fsync) { } TEST_KILL_RANDOM("WritableFileWriter::Sync:1", rocksdb_kill_odds); pending_sync_ = false; - if (use_fsync) { - pending_fsync_ = false; - } return Status::OK(); } diff --git a/util/file_reader_writer.h b/util/file_reader_writer.h index 1a7b81bed..d4406dfbf 100644 --- a/util/file_reader_writer.h +++ b/util/file_reader_writer.h @@ -102,7 +102,6 @@ class WritableFileWriter { // so we need to go back and write that page again uint64_t next_write_offset_; bool pending_sync_; - bool pending_fsync_; const bool direct_io_; const bool use_os_buffer_; uint64_t last_sync_size_; @@ -118,7 +117,6 @@ class WritableFileWriter { filesize_(0), next_write_offset_(0), pending_sync_(false), - pending_fsync_(false), direct_io_(writable_file_->UseDirectIO()), use_os_buffer_(writable_file_->UseOSBuffer()), last_sync_size_(0),