From 36fa49ceb5ebf3e6232933c0f13c1551639f6411 Mon Sep 17 00:00:00 2001 From: Daniel Black Date: Fri, 29 Jun 2018 11:42:08 -0700 Subject: [PATCH] transaction_test: -Wunused-variable with clang-7 (#4074) Summary: clang version 7.0.0- (trunk) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: /usr/bin clang++-7 -DROCKSDB_USE_RTTI -g -W -Wextra -Wall -Wsign-compare -Wshadow -Wno-unused-parameter -Werror -I. -I./include -std=c++11 -DROCKSDB_PLATFORM_POSIX -DROCKSDB_LIB_IO_POSIX -DOS_LINUX -fno-builtin-memcmp -DROCKSDB_FALLOCATE_PRESENT -DSNAPPY -DGFLAGS=google -DZLIB -DBZIP2 -DROCKSDB_MALLOC_USABLE_SIZE -DROCKSDB_PTHREAD_ADAPTIVE_MUTEX -DROCKSDB_BACKTRACE -DROCKSDB_RANGESYNC_PRESENT -DROCKSDB_SCHED_GETCPU_PRESENT -Wshorten-64-to-32 -march=native -DHAVE_SSE42 -DROCKSDB_SUPPORT_THREAD_LOCAL -isystem ./third-party/gtest-1.7.0/fused-src -DTRAVIS -O2 -fno-omit-frame-pointer -momit-leaf-frame-pointer -Woverloaded-virtual -Wnon-virtual-dtor -Wno-missing-field-initializers -c utilities/transactions/transaction_test.cc -o utilities/transactions/transaction_test.o utilities/transactions/transaction_test.cc:2282:22: error: unused variable 'txn_options' [-Werror,-Wunused-variable] TransactionOptions txn_options; ^ utilities/transactions/transaction_test.cc:2822:22: error: unused variable 'txn_options' [-Werror,-Wunused-variable] TransactionOptions txn_options; ^ utilities/transactions/transaction_test.cc:2928:22: error: unused variable 'txn_options' [-Werror,-Wunused-variable] TransactionOptions txn_options; ^ utilities/transactions/transaction_test.cc:3109:22: error: unused variable 'txn_options' [-Werror,-Wunused-variable] TransactionOptions txn_options; ^ utilities/transactions/transaction_test.cc:4364:22: error: unused variable 'txn_options' [-Werror,-Wunused-variable] TransactionOptions txn_options; ^ Closes https://github.com/facebook/rocksdb/pull/4074 Differential Revision: D8698051 Pulled By: ajkr fbshipit-source-id: 6255618eefdd189962fbea1b02cf1eb5ae501274 --- utilities/transactions/transaction_test.cc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/utilities/transactions/transaction_test.cc b/utilities/transactions/transaction_test.cc index 6eb0e06fb..a4c715578 100644 --- a/utilities/transactions/transaction_test.cc +++ b/utilities/transactions/transaction_test.cc @@ -2656,7 +2656,6 @@ TEST_P(TransactionTest, ColumnFamiliesTest) { TEST_P(TransactionTest, ColumnFamiliesTest2) { WriteOptions write_options; ReadOptions read_options, snapshot_read_options; - TransactionOptions txn_options; string value; Status s; @@ -3302,7 +3301,6 @@ TEST_P(TransactionTest, LockLimitTest) { TEST_P(TransactionTest, IteratorTest) { WriteOptions write_options; ReadOptions read_options, snapshot_read_options; - TransactionOptions txn_options; std::string value; Status s; @@ -3483,7 +3481,6 @@ TEST_P(TransactionTest, DisableIndexingTest) { TEST_P(TransactionTest, SavepointTest) { WriteOptions write_options; ReadOptions read_options, snapshot_read_options; - TransactionOptions txn_options; std::string value; Status s; @@ -4738,7 +4735,6 @@ TEST_P(TransactionTest, ClearSnapshotTest) { TEST_P(TransactionTest, ToggleAutoCompactionTest) { Status s; - TransactionOptions txn_options; ColumnFamilyHandle *cfa, *cfb; ColumnFamilyOptions cf_options;