From 3ab0eae86016740d6e405e52cc60d1707e9055a0 Mon Sep 17 00:00:00 2001 From: Levi Tamasi Date: Tue, 22 Jun 2021 17:33:15 -0700 Subject: [PATCH] Deflake BlobDBTest.SnapshotAndGarbageCollection (#8444) Summary: This test case has been failing occasionally due to automatic compactions kicking in, resulting in GC generating additional blob files that the test did not expect. Disabling automatic compactions to get rid of this flakiness. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8444 Test Plan: `gtest-parallel --repeat=1000 ./blob_db_test --gtest_filter="BlobDBTest.SnapshotAndGarbageCollection"` Reviewed By: jay-zhuang Differential Revision: D29316987 Pulled By: ltamasi fbshipit-source-id: 9815d189ed7d63890622768675a01990e3680221 --- utilities/blob_db/blob_db_test.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/utilities/blob_db/blob_db_test.cc b/utilities/blob_db/blob_db_test.cc index 84401d6bb..5a292347b 100644 --- a/utilities/blob_db/blob_db_test.cc +++ b/utilities/blob_db/blob_db_test.cc @@ -871,10 +871,13 @@ TEST_F(BlobDBTest, SnapshotAndGarbageCollection) { bdb_options.garbage_collection_cutoff = 1.0; bdb_options.disable_background_tasks = true; + Options options; + options.disable_auto_compactions = true; + // i = when to take snapshot for (int i = 0; i < 4; i++) { Destroy(); - Open(bdb_options); + Open(bdb_options, options); const Snapshot *snapshot = nullptr;