From 3db81d535a62b35a8c569d70add73d6d070cd332 Mon Sep 17 00:00:00 2001 From: Aashish Pant Date: Sun, 26 Apr 2015 21:47:30 -0700 Subject: [PATCH] Fix memory leak in cache_test introduced in the previous commit Test Plan: Verified that valgrind build passes for cache_test Reviewers: igor Reviewed By: igor Subscribers: dhruba Differential Revision: https://reviews.facebook.net/D37665 --- util/cache_test.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/util/cache_test.cc b/util/cache_test.cc index 6636bf77e..6fba6a710 100644 --- a/util/cache_test.cc +++ b/util/cache_test.cc @@ -383,6 +383,11 @@ TEST_F(CacheTest, SetCapacity) { cache->SetCapacity(7); ASSERT_EQ(7, cache->GetCapacity()); ASSERT_EQ(7, cache->GetUsage()); + + // release remaining 5 to keep valgrind happy + for (size_t i = 5; i < 10; i++) { + cache->Release(handles[i]); + } } TEST_F(CacheTest, OverCapacity) {