From 4011012d9d92658d38cdeaba310bec9189ee4d6d Mon Sep 17 00:00:00 2001 From: Yanqin Jin Date: Wed, 23 May 2018 15:59:16 -0700 Subject: [PATCH] Specify the underlying type of enums. Summary: Explicitly specify the underlying type of enums help developers understand the physical storage. Closes https://github.com/facebook/rocksdb/pull/3892 Differential Revision: D8107027 Pulled By: riversand963 fbshipit-source-id: a00efecbba46df4a3c8eed0994a2d4972ad1a1d3 --- db/version_edit.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/db/version_edit.cc b/db/version_edit.cc index dd84d0986..ad916036a 100644 --- a/db/version_edit.cc +++ b/db/version_edit.cc @@ -20,7 +20,7 @@ namespace rocksdb { // Tag numbers for serialized VersionEdit. These numbers are written to // disk and should not be changed. -enum Tag { +enum Tag : uint32_t { kComparator = 1, kLogNumber = 2, kNextFileNumber = 3, @@ -42,7 +42,7 @@ enum Tag { kMaxColumnFamily = 203, }; -enum CustomTag { +enum CustomTag : uint32_t { kTerminate = 1, // The end of customized fields kNeedCompaction = 2, // Since Manifest is not entirely currently forward-compatible, and the only