NextGraph
/
rocksdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Disable the QPS verification in test temporally (#9190)

Browse Source 
Summary:
Disable the QPS verification in test temporally, which causes the test failure due to different system delays.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/9190

Test Plan: make check

Reviewed By: siying

Differential Revision: D32576289

Pulled By: zhichao-cao

fbshipit-source-id: 1df972e77dd82eed5af3462e5db5e141aadf8fae
main
Zhichao Cao 3 years ago committed by Facebook GitHub Bot
parent 8101643611
commit 4340e1ff6d
1 changed files with 22 additions and 0 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 22
      tools/trace_analyzer_test.cc

22
tools/trace_analyzer_test.cc
Unescape View File

@ -40,6 +40,10 @@ static const int kMaxArgCount = 100;
static const size_t kArgBufferSize = 100000;
} // namespace
// Note that, the QPS part verification of the analyzing result is not robost
// enough and causes the failure in some rare cases. Disable them temporally and
// wait for future refactor.
// The helper functions for the test
class TraceAnalyzerTest : public testing::Test {
public:
@ -258,6 +262,7 @@ TEST_F(TraceAnalyzerTest, Get) {
file_path = output_path + "/test-get-0-whole_key_prefix_cut.txt";
CheckFileContent(k_whole_prefix, file_path, true);
/*
// Check the overall qps
std::vector<std::string> all_qps = {"1 0 0 0 0 0 0 0 0 1"};
file_path = output_path + "/test-qps_stats.txt";
@ -273,6 +278,7 @@ TEST_F(TraceAnalyzerTest, Get) {
"The prefix: 0x61 Access count: 1"};
file_path = output_path + "/test-get-0-accessed_top_k_qps_prefix_cut.txt";
CheckFileContent(top_qps, file_path, true);
*/
}
// Test analyzing of Put
@ -333,6 +339,7 @@ TEST_F(TraceAnalyzerTest, Put) {
file_path = output_path + "/test-qps_stats.txt";
CheckFileContent(all_qps, file_path, true);
/*
// Check the qps of Put
std::vector<std::string> get_qps = {"1"};
file_path = output_path + "/test-put-0-qps_stats.txt";
@ -349,6 +356,7 @@ TEST_F(TraceAnalyzerTest, Put) {
"Number_of_value_size_between 0 and 16 is: 1"};
file_path = output_path + "/test-put-0-accessed_value_size_distribution.txt";
CheckFileContent(value_dist, file_path, true);
*/
}
// Test analyzing of delete
@ -405,6 +413,7 @@ TEST_F(TraceAnalyzerTest, Delete) {
file_path = output_path + "/test-delete-0-whole_key_prefix_cut.txt";
CheckFileContent(k_whole_prefix, file_path, true);
/*
// Check the overall qps
std::vector<std::string> all_qps = {"0 0 1 0 0 0 0 0 0 1"};
file_path = output_path + "/test-qps_stats.txt";
@ -420,6 +429,7 @@ TEST_F(TraceAnalyzerTest, Delete) {
"The prefix: 0x63 Access count: 1"};
file_path = output_path + "/test-delete-0-accessed_top_k_qps_prefix_cut.txt";
CheckFileContent(top_qps, file_path, true);
*/
}
// Test analyzing of Merge
@ -475,6 +485,7 @@ TEST_F(TraceAnalyzerTest, Merge) {
file_path = output_path + "/test-merge-0-whole_key_prefix_cut.txt";
CheckFileContent(k_whole_prefix, file_path, true);
/*
// Check the overall qps
std::vector<std::string> all_qps = {"0 0 0 0 0 1 0 0 0 1"};
file_path = output_path + "/test-qps_stats.txt";
@ -490,6 +501,7 @@ TEST_F(TraceAnalyzerTest, Merge) {
"The prefix: 0x62 Access count: 1"};
file_path = output_path + "/test-merge-0-accessed_top_k_qps_prefix_cut.txt";
CheckFileContent(top_qps, file_path, true);
*/
// Check the value size distribution
std::vector<std::string> value_dist = {
@ -553,6 +565,7 @@ TEST_F(TraceAnalyzerTest, SingleDelete) {
file_path = output_path + "/test-single_delete-0-whole_key_prefix_cut.txt";
CheckFileContent(k_whole_prefix, file_path, true);
/*
// Check the overall qps
std::vector<std::string> all_qps = {"0 0 0 1 0 0 0 0 0 1"};
file_path = output_path + "/test-qps_stats.txt";
@ -569,6 +582,7 @@ TEST_F(TraceAnalyzerTest, SingleDelete) {
file_path =
output_path + "/test-single_delete-0-accessed_top_k_qps_prefix_cut.txt";
CheckFileContent(top_qps, file_path, true);
*/
}
// Test analyzing of delete
@ -626,6 +640,7 @@ TEST_F(TraceAnalyzerTest, DeleteRange) {
file_path = output_path + "/test-range_delete-0-whole_key_prefix_cut.txt";
CheckFileContent(k_whole_prefix, file_path, true);
/*
// Check the overall qps
std::vector<std::string> all_qps = {"0 0 0 0 2 0 0 0 0 2"};
file_path = output_path + "/test-qps_stats.txt";
@ -643,6 +658,7 @@ TEST_F(TraceAnalyzerTest, DeleteRange) {
file_path =
output_path + "/test-range_delete-0-accessed_top_k_qps_prefix_cut.txt";
CheckFileContent(top_qps, file_path, true);
*/
}
// Test analyzing of Iterator
@ -700,6 +716,7 @@ TEST_F(TraceAnalyzerTest, Iterator) {
file_path = output_path + "/test-iterator_Seek-0-whole_key_prefix_cut.txt";
CheckFileContent(k_whole_prefix, file_path, true);
/*
// Check the overall qps
std::vector<std::string> all_qps = {"0 0 0 0 0 0 1 1 0 2"};
file_path = output_path + "/test-qps_stats.txt";
@ -716,6 +733,7 @@ TEST_F(TraceAnalyzerTest, Iterator) {
file_path =
output_path + "/test-iterator_Seek-0-accessed_top_k_qps_prefix_cut.txt";
CheckFileContent(top_qps, file_path, true);
*/
// Check the output of SeekForPrev
// check the key_stats file
@ -753,6 +771,7 @@ TEST_F(TraceAnalyzerTest, Iterator) {
output_path + "/test-iterator_SeekForPrev-0-whole_key_prefix_cut.txt";
CheckFileContent(k_whole_prefix, file_path, true);
/*
// Check the qps of Iterator_SeekForPrev
get_qps = {"1"};
file_path = output_path + "/test-iterator_SeekForPrev-0-qps_stats.txt";
@ -763,6 +782,7 @@ TEST_F(TraceAnalyzerTest, Iterator) {
file_path = output_path +
"/test-iterator_SeekForPrev-0-accessed_top_k_qps_prefix_cut.txt";
CheckFileContent(top_qps, file_path, true);
*/
}
// Test analyzing of multiget
@ -827,6 +847,7 @@ TEST_F(TraceAnalyzerTest, MultiGet) {
file_path = output_path + "/test-multiget-0-whole_key_prefix_cut.txt";
CheckFileContent(k_whole_prefix, file_path, true);
/*
// Check the overall qps. We have 3 MultiGet queries and it requested 9 keys
// in total
std::vector<std::string> all_qps = {"0 0 0 0 2 0 0 0 9 11"};
@ -846,6 +867,7 @@ TEST_F(TraceAnalyzerTest, MultiGet) {
file_path =
output_path + "/test-multiget-0-accessed_top_k_qps_prefix_cut.txt";
CheckFileContent(top_qps, file_path, true);
*/
}
} // namespace ROCKSDB_NAMESPACE

Write Preview
Loading…
Cancel
Save