From 48c468c22e2a5ec5bcd39c8d3a6787c3973c7add Mon Sep 17 00:00:00 2001
From: Adam Retter <adam.retter@googlemail.com>
Date: Mon, 16 Aug 2021 06:24:35 -0700
Subject: [PATCH] Use non-zero exit codes in benchmark.sh when the benchmark
 cannot be run (#8554)

Summary: Pull Request resolved: https://github.com/facebook/rocksdb/pull/8554

Reviewed By: ajkr

Differential Revision: D29756562

Pulled By: mrambacher

fbshipit-source-id: ab2f5ef988c8ac7ea7c633e6a3dacaf16f021529
---
 tools/benchmark.sh | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/tools/benchmark.sh b/tools/benchmark.sh
index 37c58a00b..a6acfa73f 100755
--- a/tools/benchmark.sh
+++ b/tools/benchmark.sh
@@ -2,13 +2,17 @@
 # Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
 # REQUIRE: db_bench binary exists in the current directory
 
+EXIT_INVALID_ARGS=1
+EXIT_NOT_COMPACTION_TEST=2
+EXIT_UNKNOWN_JOB=3
+
 if [ $# -lt 1 ]; then
   echo -n "./benchmark.sh [bulkload/fillseq_disable_wal/fillseq_enable_wal/overwrite/"
   echo    "updaterandom/readrandom/mergerandom/filluniquerandom/multireadrandom/"
   echo    "fwdrange/revrange/readwhilewriting/readwhilemerging/"
   echo    "fwdrangewhilewriting/revrangewhilewriting/fwdrangewhilemerging/revrangewhilemerging/"
   echo    "randomtransaction/universal_compaction/debug]"
-  exit 0
+  exit $EXIT_INVALID_ARGS
 fi
 bench_cmd=$1
 shift
@@ -19,7 +23,7 @@ bench_args=$*
 # rest of the benchmarks helps.
 if [ "$COMPACTION_TEST" == "1" -a "$bench_cmd" != "universal_compaction" ]; then
   echo "Skipping $1 because it's not a compaction test."
-  exit 0
+  exit $EXIT_NOT_COMPACTION_TEST
 fi
 
 # size constants
@@ -30,12 +34,12 @@ T=$((1024 * G))
 
 if [ -z $DB_DIR ]; then
   echo "DB_DIR is not defined"
-  exit 0
+  exit $EXIT_INVALID_ARGS
 fi
 
 if [ -z $WAL_DIR ]; then
   echo "WAL_DIR is not defined"
-  exit 0
+  exit $EXIT_INVALID_ARGS
 fi
 
 output_dir=${OUTPUT_DIR:-/tmp/}
@@ -543,7 +547,7 @@ for job in ${jobs[@]}; do
     echo "Setting num_keys to $num_keys"
   else
     echo "unknown job $job"
-    exit
+    exit $EXIT_UNKNOWN_JOB
   fi
   end=$(now)