From 4d5b575563a43287b71751947801f4f090e3126f Mon Sep 17 00:00:00 2001 From: Stiopa Koltsov Date: Fri, 4 Jun 2021 13:18:04 -0700 Subject: [PATCH] Enable Starlark for fbcode//i* Summary: #forcetdhashing Reviewed By: ndmitchell Differential Revision: D28873060 fbshipit-source-id: 7d3be3e7d38619ec5b0b117f462ca1b9f427aa94 --- TARGETS | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/TARGETS b/TARGETS index 226c850c6..1f8c57f65 100644 --- a/TARGETS +++ b/TARGETS @@ -10,7 +10,7 @@ load(":defs.bzl", "test_binary") REPO_PATH = package_name() + "/" -ROCKSDB_COMPILER_FLAGS = [ +ROCKSDB_COMPILER_FLAGS_0 = [ "-fno-builtin-memcmp", # Needed to compile in fbcode "-Wno-expansion-to-defined", @@ -28,7 +28,7 @@ ROCKSDB_EXTERNAL_DEPS = [ ("zstd", None, "zstd"), ] -ROCKSDB_OS_DEPS = [ +ROCKSDB_OS_DEPS_0 = [ ( "linux", ["third-party//numa:numa", "third-party//liburing:uring", "third-party//tbb:tbb"], @@ -39,7 +39,7 @@ ROCKSDB_OS_DEPS = [ ), ] -ROCKSDB_OS_PREPROCESSOR_FLAGS = [ +ROCKSDB_OS_PREPROCESSOR_FLAGS_0 = [ ( "linux", [ @@ -107,18 +107,18 @@ is_opt_mode = build_mode.startswith("opt") # -DNDEBUG is added by default in opt mode in fbcode. But adding it twice # doesn't harm and avoid forgetting to add it. -ROCKSDB_COMPILER_FLAGS += (["-DNDEBUG"] if is_opt_mode else []) +ROCKSDB_COMPILER_FLAGS = ROCKSDB_COMPILER_FLAGS_0 + (["-DNDEBUG"] if is_opt_mode else []) sanitizer = read_config("fbcode", "sanitizer") # Do not enable jemalloc if sanitizer presents. RocksDB will further detect # whether the binary is linked with jemalloc at runtime. -ROCKSDB_OS_PREPROCESSOR_FLAGS += ([( +ROCKSDB_OS_PREPROCESSOR_FLAGS = ROCKSDB_OS_PREPROCESSOR_FLAGS_0 + ([( "linux", ["-DROCKSDB_JEMALLOC"], )] if sanitizer == "" else []) -ROCKSDB_OS_DEPS += ([( +ROCKSDB_OS_DEPS = ROCKSDB_OS_DEPS_0 + ([( "linux", ["third-party//jemalloc:headers"], )] if sanitizer == "" else [])