From 51fce92e113587c4cbea686f93c84173bdb8707a Mon Sep 17 00:00:00 2001 From: sdong Date: Tue, 17 Nov 2015 14:45:26 -0800 Subject: [PATCH] "ldb compact" should force bottommost level compaction Summary: Now "ldb compact" skips the bottommost level compaction. This is an unintended behavior change. Reverting it now. Maybe we need to add another mode later for it. Test Plan: Run a manual test of 'ldb' to make sure bottom most level is compacted. Reviewers: IslamAbdelRahman, yhchiang, anthony, kradhakrishnan, rven Reviewed By: rven Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D50925 --- tools/ldb_cmd.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/ldb_cmd.cc b/tools/ldb_cmd.cc index 60687f98d..93c82fb43 100644 --- a/tools/ldb_cmd.cc +++ b/tools/ldb_cmd.cc @@ -449,7 +449,10 @@ void CompactorCommand::DoCommand() { end = new Slice(to_); } - db_->CompactRange(CompactRangeOptions(), begin, end); + CompactRangeOptions cro; + cro.bottommost_level_compaction = BottommostLevelCompaction::kForce; + + db_->CompactRange(cro, begin, end); exec_state_ = LDBCommandExecuteResult::Succeed(""); delete begin;