diff --git a/Makefile b/Makefile index 46edebfce..6177c136c 100644 --- a/Makefile +++ b/Makefile @@ -560,6 +560,8 @@ ifdef ASSERT_STATUS_CHECKED TESTS_PASSING_ASC = \ arena_test \ autovector_test \ + cache_test \ + lru_cache_test \ blob_file_addition_test \ blob_file_garbage_test \ bloom_test \ @@ -571,6 +573,7 @@ ifdef ASSERT_STATUS_CHECKED crc32c_test \ dbformat_test \ defer_test \ + filename_test \ dynamic_bloom_test \ env_basic_test \ env_test \ @@ -599,6 +602,7 @@ ifdef ASSERT_STATUS_CHECKED statistics_test \ thread_local_test \ env_timed_test \ + filelock_test \ timer_queue_test \ timer_test \ util_merge_operators_test \ diff --git a/cache/cache_test.cc b/cache/cache_test.cc index ceafefe6f..40d8c42cc 100644 --- a/cache/cache_test.cc +++ b/cache/cache_test.cc @@ -117,8 +117,8 @@ class CacheTest : public testing::TestWithParam { void Insert(std::shared_ptr cache, int key, int value, int charge = 1) { - cache->Insert(EncodeKey(key), EncodeValue(value), charge, - &CacheTest::Deleter); + EXPECT_OK(cache->Insert(EncodeKey(key), EncodeValue(value), charge, + &CacheTest::Deleter)); } void Erase(std::shared_ptr cache, int key) { @@ -167,9 +167,10 @@ TEST_P(CacheTest, UsageTest) { for (int i = 1; i < 100; ++i) { std::string key(i, 'a'); auto kv_size = key.size() + 5; - cache->Insert(key, reinterpret_cast(value), kv_size, dumbDeleter); - precise_cache->Insert(key, reinterpret_cast(value), kv_size, - dumbDeleter); + ASSERT_OK(cache->Insert(key, reinterpret_cast(value), kv_size, + dumbDeleter)); + ASSERT_OK(precise_cache->Insert(key, reinterpret_cast(value), + kv_size, dumbDeleter)); usage += kv_size; ASSERT_EQ(usage, cache->GetUsage()); ASSERT_LT(usage, precise_cache->GetUsage()); @@ -183,10 +184,10 @@ TEST_P(CacheTest, UsageTest) { // make sure the cache will be overloaded for (uint64_t i = 1; i < kCapacity; ++i) { auto key = ToString(i); - cache->Insert(key, reinterpret_cast(value), key.size() + 5, - dumbDeleter); - precise_cache->Insert(key, reinterpret_cast(value), key.size() + 5, - dumbDeleter); + ASSERT_OK(cache->Insert(key, reinterpret_cast(value), key.size() + 5, + dumbDeleter)); + ASSERT_OK(precise_cache->Insert(key, reinterpret_cast(value), + key.size() + 5, dumbDeleter)); } // the usage should be close to the capacity @@ -215,11 +216,12 @@ TEST_P(CacheTest, PinnedUsageTest) { auto kv_size = key.size() + 5; Cache::Handle* handle; Cache::Handle* handle_in_precise_cache; - cache->Insert(key, reinterpret_cast(value), kv_size, dumbDeleter, - &handle); + ASSERT_OK(cache->Insert(key, reinterpret_cast(value), kv_size, + dumbDeleter, &handle)); assert(handle); - precise_cache->Insert(key, reinterpret_cast(value), kv_size, - dumbDeleter, &handle_in_precise_cache); + ASSERT_OK(precise_cache->Insert(key, reinterpret_cast(value), + kv_size, dumbDeleter, + &handle_in_precise_cache)); assert(handle_in_precise_cache); pinned_usage += kv_size; ASSERT_EQ(pinned_usage, cache->GetPinnedUsage()); @@ -254,10 +256,10 @@ TEST_P(CacheTest, PinnedUsageTest) { // check that overloading the cache does not change the pinned usage for (uint64_t i = 1; i < 2 * kCapacity; ++i) { auto key = ToString(i); - cache->Insert(key, reinterpret_cast(value), key.size() + 5, - dumbDeleter); - precise_cache->Insert(key, reinterpret_cast(value), key.size() + 5, - dumbDeleter); + ASSERT_OK(cache->Insert(key, reinterpret_cast(value), key.size() + 5, + dumbDeleter)); + ASSERT_OK(precise_cache->Insert(key, reinterpret_cast(value), + key.size() + 5, dumbDeleter)); } ASSERT_EQ(pinned_usage, cache->GetPinnedUsage()); ASSERT_EQ(precise_cache_pinned_usage, precise_cache->GetPinnedUsage()); diff --git a/cache/lru_cache_test.cc b/cache/lru_cache_test.cc index f777711f1..08c05024a 100644 --- a/cache/lru_cache_test.cc +++ b/cache/lru_cache_test.cc @@ -37,8 +37,9 @@ class LRUCacheTest : public testing::Test { void Insert(const std::string& key, Cache::Priority priority = Cache::Priority::LOW) { - cache_->Insert(key, 0 /*hash*/, nullptr /*value*/, 1 /*charge*/, - nullptr /*deleter*/, nullptr /*handle*/, priority); + EXPECT_OK(cache_->Insert(key, 0 /*hash*/, nullptr /*value*/, 1 /*charge*/, + nullptr /*deleter*/, nullptr /*handle*/, + priority)); } void Insert(char key, Cache::Priority priority = Cache::Priority::LOW) { diff --git a/db/filename_test.cc b/db/filename_test.cc index 9a04542f6..1e53c9520 100644 --- a/db/filename_test.cc +++ b/db/filename_test.cc @@ -108,7 +108,7 @@ TEST_F(FileNameTest, Parse) { TEST_F(FileNameTest, InfoLogFileName) { std::string dbname = ("/data/rocksdb"); std::string db_absolute_path; - Env::Default()->GetAbsolutePath(dbname, &db_absolute_path); + ASSERT_OK(Env::Default()->GetAbsolutePath(dbname, &db_absolute_path)); ASSERT_EQ("/data/rocksdb/LOG", InfoLogFileName(dbname, db_absolute_path, "")); ASSERT_EQ("/data/rocksdb/LOG.old.666",