From 5ac16300b010281d49140b61e562a5bba119489f Mon Sep 17 00:00:00 2001 From: Yueh-Hsuan Chiang Date: Thu, 12 Nov 2015 14:12:27 -0800 Subject: [PATCH] Fixed valgrind error in options_util_test Summary: Fixed valgrind error in options_util_test by deleting the compaction_filter allocated from RandomInitCFOptions(). Test Plan: valgrind --error-exitcode=2 --leak-check=full ./options_util_test Reviewers: anthony, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D50661 --- utilities/options/options_util_test.cc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/utilities/options/options_util_test.cc b/utilities/options/options_util_test.cc index 0ad29fb4b..a017f5600 100644 --- a/utilities/options/options_util_test.cc +++ b/utilities/options/options_util_test.cc @@ -80,6 +80,12 @@ TEST_F(OptionsUtilTest, SaveAndLoad) { ASSERT_NOK(RocksDBOptionsParser::VerifyCFOptions( cf_opts[i], loaded_cf_descs[i].options)); } + + for (size_t i = 0; i < kCFCount; ++i) { + if (cf_opts[i].compaction_filter) { + delete cf_opts[i].compaction_filter; + } + } } } // namespace rocksdb