From 5dae0194776f7763d4356844b93cfba9e4fce614 Mon Sep 17 00:00:00 2001 From: Maysam Yabandeh Date: Thu, 9 Mar 2017 10:59:06 -0800 Subject: [PATCH] Revert "Report cpu usage using time command" Summary: This reverts commit d43adf21bb26c2dd89d2942895c376dd4775455c. The patch has caused problems in regression tests. Will revert it for now until we figure how to debug the problems regression tests. Closes https://github.com/facebook/rocksdb/pull/1975 Differential Revision: D4682880 Pulled By: maysamyabandeh fbshipit-source-id: 84df83a --- tools/regression_test.sh | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/tools/regression_test.sh b/tools/regression_test.sh index 416c5395b..94d27e48d 100755 --- a/tools/regression_test.sh +++ b/tools/regression_test.sh @@ -167,8 +167,7 @@ function run_db_bench { db_bench_error=0 options_file_arg=$(setup_options_file) echo "$options_file_arg" - # use `which time` to avoid using bash's internal time command - db_bench_cmd="(`which time` -p $DB_BENCH_DIR/db_bench \ + db_bench_cmd="$DB_BENCH_DIR/db_bench \ --benchmarks=$1 --db=$DB_PATH --wal_dir=$WAL_PATH \ --use_existing_db=$USE_EXISTING_DB \ --disable_auto_compactions \ @@ -190,7 +189,7 @@ function run_db_bench { --max_background_flushes=$MAX_BACKGROUND_FLUSHES \ --num_multi_db=$NUM_MULTI_DB \ --max_background_compactions=$MAX_BACKGROUND_COMPACTIONS \ - --seed=$SEED) 2>&1" + --seed=$SEED 2>&1" kill_db_bench_cmd="pkill db_bench" ps_cmd="ps aux" if ! [ -z "$REMOTE_USER_AT_HOST" ]; then @@ -259,12 +258,7 @@ function update_report { perc[3]=${BASH_REMATCH[4]} # p99.9 perc[4]=${BASH_REMATCH[5]} # p99.99 - # parse the output of the time command - real_sec=`tail -3 $2 | grep real | awk '{print $2}'` - user_sec=`tail -3 $2 | grep user | awk '{print $2}'` - sys_sec=`tail -3 $2 | grep sys | awk '{print $2}'` - - (printf "$COMMIT_ID,%25s,%30s,%7s,%9s,%8s,%10s,%13.0f,%14s,%11s,%12s,%7s,%11s,%9.0f,%10.0f,%10.0f,%10.0f,%10.0f,%10.0f,%5.0f,%5.0f,%5.0f\n" \ + (printf "$COMMIT_ID,%25s,%30s,%7s,%9s,%8s,%10s,%13.0f,%14s,%11s,%12s,%7s,%11s,%9.0f,%10.0f,%10.0f,%10.0f,%10.0f,%10.0f\n" \ $1 $REMOTE_USER_AT_HOST $NUM_MULTI_DB $NUM_KEYS $KEY_SIZE $VALUE_SIZE \ $(multiply $COMPRESSION_RATIO 100) \ $3 $4 $CACHE_SIZE \ @@ -275,9 +269,6 @@ function update_report { $(multiply ${perc[2]} 1000) \ $(multiply ${perc[3]} 1000) \ $(multiply ${perc[4]} 1000) \ - $real_sec \ - $user_sec \ - $sys_sec \ >> $SUMMARY_FILE) exit_on_error $? } @@ -367,13 +358,12 @@ function setup_test_directory { run_local "mkdir -p $RESULT_PATH" - (printf "%40s,%25s,%30s,%7s,%9s,%8s,%10s,%13s,%14s,%11s,%12s,%7s,%11s,%9s,%10s,%10s,%10s,%10s,%10s,%5s,%5s,%5s\n" \ + (printf "%40s,%25s,%30s,%7s,%9s,%8s,%10s,%13s,%14s,%11s,%12s,%7s,%11s,%9s,%10s,%10s,%10s,%10s,%10s\n" \ "commit id" "benchmark" "user@host" "num-dbs" \ "key-range" "key-size" "value-size" "compress-rate" \ "ops-per-thread" "num-threads" "cache-size" \ "flushes" "compactions" \ "us-per-op" "p50" "p75" "p99" "p99.9" "p99.99" \ - "real-sec" "user-sec" "sys-sec" \ >> $SUMMARY_FILE) exit_on_error $? }