From 5f33436285c532936de8870bf22badf1568366dd Mon Sep 17 00:00:00 2001 From: sdong Date: Wed, 30 Sep 2020 11:37:11 -0700 Subject: [PATCH] Revert an uncessary status code check skipping (#7458) Summary: https://github.com/facebook/rocksdb/pull/7452 added an uncessary skip for status code checking. Revert it. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7458 Test Plan: Watch CI to finish Reviewed By: jay-zhuang Differential Revision: D23994390 fbshipit-source-id: a2b50a6326d8073db3386bff3d32acc5a6666e9b --- db/version_set.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/db/version_set.cc b/db/version_set.cc index 471bf1da5..e94f5870d 100644 --- a/db/version_set.cc +++ b/db/version_set.cc @@ -1836,8 +1836,6 @@ void Version::Get(const ReadOptions& read_options, const LookupKey& k, GetPerfLevel() >= PerfLevel::kEnableTimeExceptForMutex && get_perf_context()->per_level_perf_context_enabled; StopWatchNano timer(env_, timer_enabled /* auto_start */); - // Something feels not right here. Should investigate more. - status->PermitUncheckedError(); *status = table_cache_->Get( read_options, *internal_comparator(), *f->file_metadata, ikey, &get_context, mutable_cf_options_.prefix_extractor.get(),