From 628dc2aad909c86dbec7b96e8334eeac78a92e8f Mon Sep 17 00:00:00 2001 From: Dhruba Borthakur Date: Tue, 8 Jan 2013 10:03:36 -0800 Subject: [PATCH] db_bench should use the default value for max_grandparent_overlap_factor. Summary: This was a peformance regression caused by https://reviews.facebook.net/D6729. The default value of max_grandparent_overlap_factor was erroneously set to 0 in db_bench. This was causing compactions to create really really small files because the max_grandparent_overlap_factor was erroneously set to zero in the benchmark. Test Plan: Run --benchmarks=overwrite Reviewers: heyongqiang, emayanke, sheki, MarkCallaghan Reviewed By: sheki CC: leveldb Differential Revision: https://reviews.facebook.net/D7797 --- db/db_bench.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/db/db_bench.cc b/db/db_bench.cc index 8122a1e7b..8d07f59bc 100644 --- a/db/db_bench.cc +++ b/db/db_bench.cc @@ -219,7 +219,7 @@ static double FLAGS_rate_limit = 0; // Control maximum bytes of overlaps in grandparent (i.e., level+2) before we // stop building a single file in a level->level+1 compaction. -static int FLAGS_max_grandparent_overlap_factor; +static int FLAGS_max_grandparent_overlap_factor = 10; // Run read only benchmarks. static bool FLAGS_read_only = false;