From 63cf15bb9f6767a85037e999a35bc8f2a93982b8 Mon Sep 17 00:00:00 2001
From: sdong <siying.d@fb.com>
Date: Mon, 11 Apr 2016 14:57:27 -0700
Subject: [PATCH] Fix option settable tests

Summary: In option settable tests, bytes for pointers are not all skipped, so that they may be the same as the special character and cause false positive.

Test Plan: Run the test. Manually verify the issue is not there any more.

Reviewers: IslamAbdelRahman, andrewkr

Reviewed By: IslamAbdelRahman

Subscribers: kradhakrishnan, yiwu, yhchiang, leveldb, andrewkr, dhruba

Differential Revision: https://reviews.facebook.net/D56553
---
 util/options_settable_test.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/options_settable_test.cc b/util/options_settable_test.cc
index 0cbcdaee3..374b95115 100644
--- a/util/options_settable_test.cc
+++ b/util/options_settable_test.cc
@@ -75,8 +75,8 @@ int NumUnsetBytes(char* start_ptr, size_t total_size,
       if (*ptr == kSpecialChar) {
         total_unset_bytes_base++;
       }
-      offset = pair.first + pair.second;
     }
+    offset = pair.first + pair.second;
   }
   for (char* ptr = start_ptr + offset; ptr < start_ptr + total_size; ptr++) {
     if (*ptr == kSpecialChar) {