From 64855979aeb74ae4eaa5b6576243a132ae2267bc Mon Sep 17 00:00:00 2001 From: Maysam Yabandeh Date: Mon, 12 Aug 2019 12:17:26 -0700 Subject: [PATCH] WriteUnPrepared: Pass snap_released to the callback (#5691) Summary: With changes made in https://github.com/facebook/rocksdb/pull/5664 we meant to pass snap_released parameter of ::IsInSnapshot from the read callbacks. Although the variable was defined, passing it to the callback in WritePreparedTxnReadCallback was missing, which is fixed in this PR. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5691 Differential Revision: D16767310 Pulled By: maysamyabandeh fbshipit-source-id: 3bf53f5964a2756a66ceef7c8f6b3ac75f102f48 --- utilities/transactions/write_unprepared_txn.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/utilities/transactions/write_unprepared_txn.cc b/utilities/transactions/write_unprepared_txn.cc index 85a38981c..761da30af 100644 --- a/utilities/transactions/write_unprepared_txn.cc +++ b/utilities/transactions/write_unprepared_txn.cc @@ -26,7 +26,8 @@ bool WriteUnpreparedTxnReadCallback::IsVisibleFullCheck(SequenceNumber seq) { } bool snap_released = false; - auto ret = db_->IsInSnapshot(seq, wup_snapshot_, min_uncommitted_); + auto ret = + db_->IsInSnapshot(seq, wup_snapshot_, min_uncommitted_, &snap_released); assert(!snap_released || backed_by_snapshot_ == kUnbackedByDBSnapshot); snap_released_ |= snap_released; return ret;