From 659d0e602e390cd4c4bcd2a26e322d38e657ab18 Mon Sep 17 00:00:00 2001 From: Maggie Moss Date: Mon, 19 Nov 2018 11:52:15 -0800 Subject: [PATCH] Run Define codemod in fbcode Summary: Found a callsite for `moo_translate` in the Scuba warnings and realized we have a few calls to `define()` left in fbcode. - I ran the `DefineCodemod` script against fbcode - Fixed broken tests, and ensured that tests that are explicitly testing the behaviour of `define()` were not changed. bypass-lint Reviewed By: kmeht Differential Revision: D12968447 fbshipit-source-id: d8fd3649a2ce9868b8938d293e1bebf1a6d2fad8 --- build_tools/RocksDBCommonHelper.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/build_tools/RocksDBCommonHelper.php b/build_tools/RocksDBCommonHelper.php index 9fe770fe9..4f4663cbe 100644 --- a/build_tools/RocksDBCommonHelper.php +++ b/build_tools/RocksDBCommonHelper.php @@ -7,12 +7,12 @@ // Name of the environment variables which need to be set by the entity which // triggers continuous runs so that code at the end of the file gets executed // and Sandcastle run starts. -define("ENV_POST_RECEIVE_HOOK", "POST_RECEIVE_HOOK"); -define("ENV_HTTPS_APP_VALUE", "HTTPS_APP_VALUE"); -define("ENV_HTTPS_TOKEN_VALUE", "HTTPS_TOKEN_VALUE"); +const ENV_POST_RECEIVE_HOOK = "POST_RECEIVE_HOOK"; +const ENV_HTTPS_APP_VALUE = "HTTPS_APP_VALUE"; +const ENV_HTTPS_TOKEN_VALUE = "HTTPS_TOKEN_VALUE"; -define("PRIMARY_TOKEN_FILE", '/home/krad/.sandcastle'); -define("CONT_RUN_ALIAS", "leveldb"); +const PRIMARY_TOKEN_FILE = '/home/krad/.sandcastle'; +const CONT_RUN_ALIAS = "leveldb"; ////////////////////////////////////////////////////////////////////// /* Run tests in sandcastle */