From 666fb5df43ddff25d6a595e50672c6f38222dc50 Mon Sep 17 00:00:00 2001 From: sdong Date: Tue, 13 Oct 2015 17:26:14 -0700 Subject: [PATCH] Remove DefaultCompactionFilterFactory. Summary: DefaultCompactionFilterFactory is not used anymore after recent changes. Remove it. Test Plan: Just run existing tests. Reviewers: rven, igor, yhchiang, kradhakrishnan, anthony, IslamAbdelRahman Reviewed By: IslamAbdelRahman Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D48699 --- HISTORY.md | 1 + include/rocksdb/compaction_filter.h | 14 -------------- 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/HISTORY.md b/HISTORY.md index 7493da314..990f7c071 100644 --- a/HISTORY.md +++ b/HISTORY.md @@ -5,6 +5,7 @@ * CompactionFilter::Context includes information of Column Family ID * The need-compaction hint given by TablePropertiesCollector::NeedCompact() will be persistent and recoverable after DB recovery. This introduces a breaking format change. If you use this experimental feature, including NewCompactOnDeletionCollectorFactory() in the new version, you may not be able to directly downgrade the DB back to version 4.0 or lower. * TablePropertiesCollectorFactory::CreateTablePropertiesCollector() now takes an option Context, containing the information of column family ID for the file being written. +* Remove DefaultCompactionFilterFactory. ## 4.1.0 (10/8/2015) ### New Features diff --git a/include/rocksdb/compaction_filter.h b/include/rocksdb/compaction_filter.h index b3d42ca33..89558f208 100644 --- a/include/rocksdb/compaction_filter.h +++ b/include/rocksdb/compaction_filter.h @@ -116,20 +116,6 @@ class CompactionFilterFactory { virtual const char* Name() const = 0; }; -// Default implementation of CompactionFilterFactory which does not -// return any filter -class DefaultCompactionFilterFactory : public CompactionFilterFactory { - public: - virtual std::unique_ptr CreateCompactionFilter( - const CompactionFilter::Context& context) override { - return std::unique_ptr(nullptr); - } - - virtual const char* Name() const override { - return "DefaultCompactionFilterFactory"; - } -}; - } // namespace rocksdb #endif // STORAGE_ROCKSDB_INCLUDE_COMPACTION_FILTER_H_