From 6d5e8604f1b22462fcf78c1ea274ec3ed44e8924 Mon Sep 17 00:00:00 2001 From: akankshamahajan Date: Tue, 14 Feb 2023 18:54:47 -0800 Subject: [PATCH] Fix regression script for async_io benchmarks (#11224) Summary: Fix regression script for async_io benchmark using incorrect ops and threads and wrong benchmark name during reporting results. Pull Request resolved: https://github.com/facebook/rocksdb/pull/11224 Test Plan: Ran manually Reviewed By: anand1976 Differential Revision: D43287658 Pulled By: akankshamahajan15 fbshipit-source-id: 433e2caa0e51268e72a875549ab8f7f92a7a4216 --- tools/regression_test.sh | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tools/regression_test.sh b/tools/regression_test.sh index 4fa6d87b8..39106af17 100755 --- a/tools/regression_test.sh +++ b/tools/regression_test.sh @@ -143,8 +143,9 @@ function main { run_db_bench "seekrandom" run_db_bench "seekrandomwhilewriting" run_db_bench "multireadrandom" - run_db_bench "seekrandom_asyncio" $NUM_KEYS 1 0 0 true - run_db_bench "multireadrandom_asyncio" $NUM_KEYS 1 0 0 true + # run_db_bench benchmark_name NUM_OPS NUM_THREADS USED_EXISTING_DB UPDATE_REPORT ASYNC_IO + run_db_bench "seekrandom_asyncio" $NUM_OPS $NUM_THREADS 1 1 true + run_db_bench "multireadrandom_asyncio" $NUM_OPS $NUM_THREADS 1 1 true fi cleanup_test_directory $TEST_ROOT_DIR @@ -202,7 +203,7 @@ function init_arguments { } # $1 --- benchmark name -# $2 --- number of operations. Default: $NUM_KEYS +# $2 --- number of operations. Default: $NUM_OPS # $3 --- number of threads. Default $NUM_THREADS # $4 --- use_existing_db. Default: 1 # $5 --- update_report. Default: 1 @@ -334,7 +335,10 @@ function multiply { # $1 --- name of the benchmark # $2 --- the filename of the output log of db_bench function update_report { - main_result=`cat $2 | grep $1` + # In case of async_io, benchmark is benchmark_asyncio + db_bench_type=${1%%_*} + + main_result=`cat $2 | grep $db_bench_type` exit_on_error $? perc_statement=`cat $2 | grep Percentile` exit_on_error $?