Rename iterator property "rocksdb.iterator.is.key.pinned" => "rocksdb.iterator.is-key-pinned"

Summary: Rename iterator property to folow property naming convention.

Test Plan: Run all existing tests.

Reviewers: andrewkr, anthony, yhchiang, kradhakrishnan, IslamAbdelRahman

Reviewed By: IslamAbdelRahman

Subscribers: leveldb, dhruba

Differential Revision: https://reviews.facebook.net/D54957

db/db_iter.cc

@@ -142,7 +142,7 @@ class DBIter: public Iterator {
     if (prop == nullptr) {
       return Status::InvalidArgument("prop is nullptr");
     }
-    if (prop_name == "rocksdb.iterator.is.key.pinned") {
+    if (prop_name == "rocksdb.iterator.is-key-pinned") {
       if (valid_) {
         *prop = (iter_pinned_ && saved_key_.IsKeyPinned()) ? "1" : "0";
       } else {

db/db_test.cc

@@ -644,10 +644,10 @@ TEST_F(DBTest, IteratorProperty) {
     iter->SeekToFirst();
     std::string prop_value;
     ASSERT_NOK(iter->GetProperty("non_existing.value", &prop_value));
-    ASSERT_OK(iter->GetProperty("rocksdb.iterator.is.key.pinned", &prop_value));
+    ASSERT_OK(iter->GetProperty("rocksdb.iterator.is-key-pinned", &prop_value));
     ASSERT_EQ("0", prop_value);
     iter->Next();
-    ASSERT_OK(iter->GetProperty("rocksdb.iterator.is.key.pinned", &prop_value));
+    ASSERT_OK(iter->GetProperty("rocksdb.iterator.is-key-pinned", &prop_value));
     ASSERT_EQ("Iterator is not valid.", prop_value);
   }
   Close();
@@ -9864,7 +9864,7 @@ TEST_F(DBTest, PinnedDataIteratorRandomized) {
         }
         std::string prop_value;
         ASSERT_OK(
-            iter->GetProperty("rocksdb.iterator.is.key.pinned", &prop_value));
+            iter->GetProperty("rocksdb.iterator.is-key-pinned", &prop_value));
         ASSERT_EQ("1", prop_value);
         keys_slices.push_back(iter->key());
         true_keys.push_back(true_data.lower_bound(k)->first);
@@ -9882,7 +9882,7 @@ TEST_F(DBTest, PinnedDataIteratorRandomized) {
       for (iter->SeekToFirst(); iter->Valid(); iter->Next()) {
         std::string prop_value;
         ASSERT_OK(
-            iter->GetProperty("rocksdb.iterator.is.key.pinned", &prop_value));
+            iter->GetProperty("rocksdb.iterator.is-key-pinned", &prop_value));
         ASSERT_EQ("1", prop_value);
         all_keys.push_back(iter->key());
       }
@@ -9903,7 +9903,7 @@ TEST_F(DBTest, PinnedDataIteratorRandomized) {
       for (iter->SeekToLast(); iter->Valid(); iter->Prev()) {
         std::string prop_value;
         ASSERT_OK(
-            iter->GetProperty("rocksdb.iterator.is.key.pinned", &prop_value));
+            iter->GetProperty("rocksdb.iterator.is-key-pinned", &prop_value));
         ASSERT_EQ("1", prop_value);
         all_keys.push_back(iter->key());
       }
@@ -9976,7 +9976,7 @@ TEST_F(DBTest, PinnedDataIteratorMultipleFiles) {
   std::vector<std::pair<Slice, std::string>> results;
   for (iter->SeekToFirst(); iter->Valid(); iter->Next()) {
     std::string prop_value;
-    ASSERT_OK(iter->GetProperty("rocksdb.iterator.is.key.pinned", &prop_value));
+    ASSERT_OK(iter->GetProperty("rocksdb.iterator.is-key-pinned", &prop_value));
     ASSERT_EQ("1", prop_value);
     results.emplace_back(iter->key(), iter->value().ToString());
   }
@@ -10031,7 +10031,7 @@ TEST_F(DBTest, PinnedDataIteratorMergeOperator) {
   std::vector<std::pair<Slice, std::string>> results;
   for (iter->SeekToFirst(); iter->Valid(); iter->Next()) {
     std::string prop_value;
-    ASSERT_OK(iter->GetProperty("rocksdb.iterator.is.key.pinned", &prop_value));
+    ASSERT_OK(iter->GetProperty("rocksdb.iterator.is-key-pinned", &prop_value));
     ASSERT_EQ("1", prop_value);
     results.emplace_back(iter->key(), iter->value().ToString());
   }
@@ -10088,7 +10088,7 @@ TEST_F(DBTest, PinnedDataIteratorReadAfterUpdate) {
   std::vector<std::pair<Slice, std::string>> results;
   for (iter->SeekToFirst(); iter->Valid(); iter->Next()) {
     std::string prop_value;
-    ASSERT_OK(iter->GetProperty("rocksdb.iterator.is.key.pinned", &prop_value));
+    ASSERT_OK(iter->GetProperty("rocksdb.iterator.is-key-pinned", &prop_value));
     ASSERT_EQ("1", prop_value);
     results.emplace_back(iter->key(), iter->value().ToString());
   }

include/rocksdb/iterator.h

@@ -96,7 +96,7 @@ class Iterator : public Cleanable {
   // satisfied without doing some IO, then this returns Status::Incomplete().
   virtual Status status() const = 0;
 
-  // Property "rocksdb.iterator.is.key.pinned":
+  // Property "rocksdb.iterator.is-key-pinned":
   //   If returning "1", this means that the Slice returned by key() is valid
   //   as long as the iterator is not deleted and ReleasePinnedData() is not
   //   called.

include/rocksdb/options.h

@@ -1400,7 +1400,7 @@ struct ReadOptions {
   // Keep the blocks loaded by the iterator pinned in memory as long as the
   // iterator is not deleted, If used when reading from tables created with
   // BlockBasedTableOptions::use_delta_encoding = false,
-  // Iterator's property "rocksdb.iterator.is.key.pinned" is guaranteed to
+  // Iterator's property "rocksdb.iterator.is-key-pinned" is guaranteed to
   // return 1.
   // Default: false
   bool pin_data;

table/iterator.cc

@@ -50,7 +50,7 @@ Status Iterator::GetProperty(std::string prop_name, std::string* prop) {
   if (prop == nullptr) {
     return Status::InvalidArgument("prop is nullptr");
   }
-  if (prop_name == "rocksdb.iterator.is.key.pinned") {
+  if (prop_name == "rocksdb.iterator.is-key-pinned") {
     *prop = "0";
     return Status::OK();
   }