From 7cc0dbd66fbd15d535858914ca644f81b1cc66ff Mon Sep 17 00:00:00 2001 From: Andrew Kryczka Date: Thu, 4 Aug 2016 23:06:28 -0700 Subject: [PATCH] cat all logs in sandcastle output Summary: Since we enabled parallelism in valgrind the logs now go to t/valgrind_log-*, which doesn't match our pattern t/log-*, so those files don't get printed in the sandcastle output. For this regex we really just want to exclude t/run-* (these are shell scripts), so let's do that explicitly. Test Plan: ran the commands locally, will also look at sandcastle results on this diff which will include these changes Reviewers: arahut, sdong, IslamAbdelRahman, kradhakrishnan, wanning Reviewed By: wanning Subscribers: andrewkr, dhruba, leveldb Differential Revision: https://reviews.facebook.net/D61557 --- arcanist_util/config/RocksDBCommonHelper.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arcanist_util/config/RocksDBCommonHelper.php b/arcanist_util/config/RocksDBCommonHelper.php index b3adf240c..28ee90a90 100644 --- a/arcanist_util/config/RocksDBCommonHelper.php +++ b/arcanist_util/config/RocksDBCommonHelper.php @@ -127,8 +127,8 @@ function getSteps($applyDiff, $diffID, $username, $test) { } $cmd = $cmd . " cat /tmp/precommit-check.log" - . "; for f in `ls t/log-*`; do echo \$f; cat \$f; done;" - . "[[ \$exit_code -eq 0 ]]"; + . "; shopt -s extglob; for f in `ls t/!(run-*)`; do echo \$f" + . "; cat \$f; done; shopt -u extglob; [[ \$exit_code -eq 0 ]]"; assert(strlen($cmd) > 0); $run_test = array(