From 81d1cdca7fc8cfff18fa36221a2022ea21e63765 Mon Sep 17 00:00:00 2001 From: Jay Zhuang Date: Thu, 24 Mar 2022 13:39:15 -0700 Subject: [PATCH] Fix make clean fail after java build (#9710) Summary: Seems clean-rocksjava and clean-rocks conflict. Also remove unnecessary step in java CI build, otherwise it will rebuild the code again as java make sample do clean up first. Pull Request resolved: https://github.com/facebook/rocksdb/pull/9710 Test Plan: `make rocksdbjava && make clean` should return success Reviewed By: riversand963 Differential Revision: D35122872 Pulled By: jay-zhuang fbshipit-source-id: 2a15b83e7a763c0fc0e42e1f35aac9551f951ece --- .circleci/config.yml | 6 ------ Makefile | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index d7e23312a..eed5a42c3 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -553,9 +553,6 @@ jobs: echo 'export PATH=$JAVA_HOME/bin:$PATH' >> $BASH_ENV which java && java -version which javac && javac -version - - run: - name: "Build RocksDBJava Shared Library" - command: make V=1 J=8 -j8 rocksdbjava - run: name: "Test RocksDBJava" command: make V=1 J=8 -j8 jtest @@ -601,9 +598,6 @@ jobs: echo 'export PATH=$JAVA_HOME/bin:$PATH' >> $BASH_ENV which java && java -version which javac && javac -version - - run: - name: "Build RocksDBJava Shared Library" - command: make V=1 J=16 -j16 rocksdbjava - run: name: "Test RocksDBJava" command: make V=1 J=16 -j16 jtest diff --git a/Makefile b/Makefile index a1d0a3303..cd134af80 100644 --- a/Makefile +++ b/Makefile @@ -1216,7 +1216,7 @@ clean-rocks: $(FIND) . -name "*.[oda]" -exec rm -f {} \; $(FIND) . -type f -regex ".*\.\(\(gcda\)\|\(gcno\)\)" -exec rm -f {} \; -clean-rocksjava: +clean-rocksjava: clean-rocks rm -rf jl jls cd java && $(MAKE) clean