From 82057b0d8f94770acc82ea8d68fa16a23ab346a9 Mon Sep 17 00:00:00 2001 From: Yanqin Jin Date: Fri, 14 Sep 2018 11:03:03 -0700 Subject: [PATCH] Improve type conversion (#4367) Summary: Use `static_cast(var)` instead of `(type)var`. Pull Request resolved: https://github.com/facebook/rocksdb/pull/4367 Differential Revision: D9833391 Pulled By: riversand963 fbshipit-source-id: 3d33fc2c290e7e0f3d1d45b256a881d1bc5a7df2 --- db/log_reader.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/db/log_reader.cc b/db/log_reader.cc index 7210e05ff..bd9d300bf 100644 --- a/db/log_reader.cc +++ b/db/log_reader.cc @@ -286,7 +286,7 @@ bool Reader::ReadMore(size_t* drop_size, int *error) { read_error_ = true; *error = kEof; return false; - } else if (buffer_.size() < (size_t)kBlockSize) { + } else if (buffer_.size() < static_cast(kBlockSize)) { eof_ = true; eof_offset_ = buffer_.size(); } @@ -311,7 +311,7 @@ bool Reader::ReadMore(size_t* drop_size, int *error) { unsigned int Reader::ReadPhysicalRecord(Slice* result, size_t* drop_size) { while (true) { // We need at least the minimum header size - if (buffer_.size() < (size_t)kHeaderSize) { + if (buffer_.size() < static_cast(kHeaderSize)) { int r; if (!ReadMore(drop_size, &r)) { return r; @@ -332,7 +332,7 @@ unsigned int Reader::ReadPhysicalRecord(Slice* result, size_t* drop_size) { } header_size = kRecyclableHeaderSize; // We need enough for the larger header - if (buffer_.size() < (size_t)kRecyclableHeaderSize) { + if (buffer_.size() < static_cast(kRecyclableHeaderSize)) { int r; if (!ReadMore(drop_size, &r)) { return r;