From 88b79b24f30092664b321bc85bd6f4f55c8d256f Mon Sep 17 00:00:00 2001 From: Kosie van der Merwe Date: Wed, 23 Jan 2013 12:49:10 -0800 Subject: [PATCH] Fixed didIO not being set with no block_cache Summary: In `Table::BlockReader()` when there was no block cache `didIO` was not set. This didn't seem to matter as `didIO` is only used to trigger seek compactions. However, I would like it if someone else could check that is the case. Test Plan: `make check OPT="-g -O3"` Reviewers: dhruba, vamsi Reviewed By: dhruba CC: leveldb Differential Revision: https://reviews.facebook.net/D8133 --- table/table.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/table/table.cc b/table/table.cc index 394f65e7d..f5bc5f0cc 100644 --- a/table/table.cc +++ b/table/table.cc @@ -207,6 +207,9 @@ Iterator* Table::BlockReader(void* arg, if (s.ok()) { block = new Block(contents); } + if (didIO != NULL) { + *didIO = true; // we did some io from storage + } } }