From 8a97c541e44c3340a7645f7ef8d1d88e63ae7516 Mon Sep 17 00:00:00 2001 From: Davide Angelocola Date: Mon, 13 Dec 2021 07:21:54 -0800 Subject: [PATCH] Fix copy constructors of Options and ColumnFamilyOptions (#9166) Summary: Looks like some fields are not copied by the copy constructor. Please confirm if it is a real issue! Pull Request resolved: https://github.com/facebook/rocksdb/pull/9166 Reviewed By: jay-zhuang Differential Revision: D32532093 Pulled By: mrambacher fbshipit-source-id: f636ef9425a530a8655947115160ae471916252b --- java/src/main/java/org/rocksdb/ColumnFamilyOptions.java | 1 + java/src/main/java/org/rocksdb/Options.java | 3 +++ 2 files changed, 4 insertions(+) diff --git a/java/src/main/java/org/rocksdb/ColumnFamilyOptions.java b/java/src/main/java/org/rocksdb/ColumnFamilyOptions.java index 9bb7e0942..fa807ae67 100644 --- a/java/src/main/java/org/rocksdb/ColumnFamilyOptions.java +++ b/java/src/main/java/org/rocksdb/ColumnFamilyOptions.java @@ -52,6 +52,7 @@ public class ColumnFamilyOptions extends RocksObject this.bottommostCompressionOptions_ = other.bottommostCompressionOptions_; this.compressionOptions_ = other.compressionOptions_; this.compactionThreadLimiter_ = other.compactionThreadLimiter_; + this.sstPartitionerFactory_ = other.sstPartitionerFactory_; } /** diff --git a/java/src/main/java/org/rocksdb/Options.java b/java/src/main/java/org/rocksdb/Options.java index f02697d77..349f3c8ec 100644 --- a/java/src/main/java/org/rocksdb/Options.java +++ b/java/src/main/java/org/rocksdb/Options.java @@ -92,6 +92,9 @@ public class Options extends RocksObject this.rowCache_ = other.rowCache_; this.writeBufferManager_ = other.writeBufferManager_; this.compactionThreadLimiter_ = other.compactionThreadLimiter_; + this.bottommostCompressionOptions_ = other.bottommostCompressionOptions_; + this.walFilter_ = other.walFilter_; + this.sstPartitionerFactory_ = other.sstPartitionerFactory_; } @Override