From 8d9a46fcd12850c9756a722bed52bdf9d9ab5916 Mon Sep 17 00:00:00 2001 From: Lei Jin Date: Thu, 3 Jul 2014 23:13:08 -0700 Subject: [PATCH] initialize decoded_internal_key_valid Summary: ReadInternalKey() will assign correct value anyway. Initialize it to true to suppress compiler error reported https://github.com/facebook/rocksdb/issues/186 Test Plan: I cannot reproduce it but this is obvious Reviewers: sdong, yhchiang Reviewed By: yhchiang Subscribers: leveldb Differential Revision: https://reviews.facebook.net/D19467 --- table/plain_table_key_coding.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/table/plain_table_key_coding.cc b/table/plain_table_key_coding.cc index 51849b3e3..eedf58aea 100644 --- a/table/plain_table_key_coding.cc +++ b/table/plain_table_key_coding.cc @@ -198,7 +198,8 @@ Status PlainTableKeyDecoder::NextPlainEncodingKey( user_key_size = static_cast(tmp_size); *bytes_read = key_ptr - start; } - bool decoded_internal_key_valid; + // dummy initial value to avoid compiler complain + bool decoded_internal_key_valid = true; Slice decoded_internal_key; Status s = ReadInternalKey(key_ptr, limit, user_key_size, parsed_key, bytes_read, @@ -227,7 +228,8 @@ Status PlainTableKeyDecoder::NextPrefixEncodingKey( bool expect_suffix = false; do { size_t size = 0; - bool decoded_internal_key_valid; + // dummy initial value to avoid compiler complain + bool decoded_internal_key_valid = true; const char* pos = DecodeSize(key_ptr, limit, &entry_type, &size); if (pos == nullptr) { return Status::Corruption("Unexpected EOF when reading size of the key");